Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Stop creating a session row for every anonymous request

Roland Geider596d4896ebb8
diff --git a/wger/core/tests/test_temporary_users.py b/wger/core/tests/test_temporary_users.py
index 594c169e0..9d96a370d 100644
--- a/wger/core/tests/test_temporary_users.py
+++ b/wger/core/tests/test_temporary_users.py
@@ -18,6 +18,7 @@ import random
# Django
from django.contrib.auth.models import User
+from django.contrib.sessions.models import Session
from django.core.management import call_command
from django.http import HttpRequest
from django.urls import reverse
@@ -53,6 +54,17 @@ class DemoUserTestCase(WgerTestCase):
"""
return User.objects.filter(userprofile__is_temporary=1).count()
+ def test_anonymous_request_creates_no_session(self):
+ """
+ Reading a public page without logging in creates no session row
+ """
+ before = Session.objects.count()
+
+ response = self.client.get(reverse('software:features'))
+
+ self.assertEqual(response.status_code, 200)
+ self.assertEqual(Session.objects.count(), before)
+
def test_demo_data_no_guest_account(self):
"""
Tests that the helper function creates demo data (workout, etc.)
diff --git a/wger/core/views/misc.py b/wger/core/views/misc.py
index 8ceb7fc7a..f274511f5 100644
--- a/wger/core/views/misc.py
+++ b/wger/core/views/misc.py
@@ -57,7 +57,7 @@ def demo_entries(request):
if (
not request.user.is_authenticated or request.user.userprofile.is_temporary
- ) and not request.session['has_demo_data']:
+ ) and not request.session.get('has_demo_data'):
# If we reach this from a page that has no user created by the
# middleware, do that now
if not request.user.is_authenticated:
diff --git a/wger/utils/middleware.py b/wger/utils/middleware.py
index fdde69f6a..b8fa61df5 100644
--- a/wger/utils/middleware.py
+++ b/wger/utils/middleware.py
@@ -58,10 +58,6 @@ def get_user(request):
create_user = check_current_request(request)
user = auth.get_user(request)
- # Set the flag in the session
- if not request.session.get('has_demo_data'):
- request.session['has_demo_data'] = False
-
# Django didn't find a user, so create one now
if (
settings.WGER_SETTINGS['ALLOW_GUEST_USERS']