Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Block API credential access during trainer-login sessions

Roland Geider6a90e34fce44
diff --git a/wger/core/templates/user/preferences.html b/wger/core/templates/user/preferences.html
index 5ccef0380..8d599c2fe 100644
--- a/wger/core/templates/user/preferences.html
+++ b/wger/core/templates/user/preferences.html
@@ -60,11 +60,13 @@
{% translate "Connected accounts" %}
</a>
{% endif %}
- <a href="{% url 'core:user:api-key' %}" class="list-group-item list-group-item-action">
- <span class="{% fa_class 'chevron-right' %} float-end text-muted"></span>
- <span class="{% fa_class 'globe' %} me-2 text-muted"></span>
- {% translate "API key" %}
- </a>
+ {% if not trainer_identity %}
+ <a href="{% url 'core:user:api-key' %}" class="list-group-item list-group-item-action">
+ <span class="{% fa_class 'chevron-right' %} float-end text-muted"></span>
+ <span class="{% fa_class 'globe' %} me-2 text-muted"></span>
+ {% translate "API key" %}
+ </a>
+ {% endif %}
{% if oidc_provider_configured %}
<a href="{% url 'core:user:connected-applications' %}"
class="list-group-item list-group-item-action">
diff --git a/wger/core/tests/test_apikey.py b/wger/core/tests/test_apikey.py
index 292067e89..06f0327b3 100644
--- a/wger/core/tests/test_apikey.py
+++ b/wger/core/tests/test_apikey.py
@@ -590,3 +590,77 @@ class LongLivedSessionBackfillTestCase(WgerTestCase):
self.index_existing_sessions()
self.assertEqual(LongLivedSession.objects.count(), 1)
+
+
+class ApiKeyTrainerLoginTestCase(WgerTestCase):
+ """
+ A trainer logged in as one of their members can't read or change the
+ member's API credentials
+ """
+
+ def setUp(self):
+ super().setUp()
+ self.member = User.objects.get(username='test')
+ self.user_login('trainer1')
+ response = self.client.post(
+ reverse('core:user:trainer-login', kwargs={'user_pk': self.member.pk})
+ )
+ self.assertEqual(response.status_code, 302)
+ self.assertTrue(self.client.session.get('trainer.identity'))
+
+ def test_token_is_not_shown(self):
+ """
+ The member's API key is not rendered
+ """
+ token = Token.objects.get(user=self.member)
+
+ response = self.client.get(reverse('core:user:api-key'))
+ self.assertEqual(response.status_code, 403)
+ self.assertNotContains(response, token.key, status_code=403)
+
+ def test_token_can_not_be_rotated(self):
+ """
+ The member's API key can't be replaced with a new one
+ """
+ key_before = Token.objects.get(user=self.member).key
+
+ response = self.client.post(reverse('core:user:api-key'), {'new_key': True})
+ self.assertEqual(response.status_code, 403)
+ self.assertEqual(Token.objects.get(user=self.member).key, key_before)
+
+ def test_token_can_not_be_deleted(self):
+ """
+ The member's API key can't be deleted
+ """
+ response = self.client.post(reverse('core:user:api-key'), {'delete_key': 'true'})
+ self.assertEqual(response.status_code, 403)
+ self.assertTrue(Token.objects.filter(user=self.member).exists())
+
+ def test_refresh_token_can_not_be_generated(self):
+ """
+ No long-lived refresh token can be minted for the member
+ """
+ response = self.client.post(reverse('core:user:api-key'), {'new_refresh_token': 'true'})
+ self.assertEqual(response.status_code, 403)
+ self.assertEqual(list_long_lived_sessions(self.member), [])
+
+ def test_jwt_sessions_can_not_be_revoked(self):
+ """
+ The member's API sessions can't be revoked
+ """
+ RefreshToken.for_user(self.member)
+
+ response = self.client.post(reverse('core:user:api-key'), {'revoke_jwt_sessions': 'true'})
+ self.assertEqual(response.status_code, 403)
+ self.assertFalse(BlacklistedToken.objects.filter(token__user=self.member).exists())
+
+ def test_page_works_again_after_switching_back(self):
+ """
+ Once back in their own account, the trainer can open their API key page
+ """
+ trainer = User.objects.get(username='trainer1')
+ self.client.post(reverse('core:user:trainer-login', kwargs={'user_pk': trainer.pk}))
+ self.assertFalse(self.client.session.get('trainer.identity'))
+
+ response = self.client.get(reverse('core:user:api-key'))
+ self.assertEqual(response.status_code, 200)
diff --git a/wger/core/views/user.py b/wger/core/views/user.py
index c8eb466e7..fb3820bac 100644
--- a/wger/core/views/user.py
+++ b/wger/core/views/user.py
@@ -518,6 +518,10 @@ def api_key(request):
Allows the user to generate an API key for the REST API
"""
+ # A trainer logged in as a member must not get credentials that outlive the session
+ if request.session.get('trainer.identity'):
+ return HttpResponseForbidden()
+
context = {}
context.update(csrf(request))