Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Only check name similarity when submitting a new exercise

Roland Geider749dd890e81f
diff --git a/docs/changelog.rst b/docs/changelog.rst
index 04fbd0ec1..603a3a972 100644
--- a/docs/changelog.rst
+++ b/docs/changelog.rst
@@ -48,7 +48,7 @@ Upgrade steps from 1.9:
* `#368`_, `#379`_, `#426`_ (thanks `@austin-leung`_), `#499`_, `#505`_, `#504`_,
`#511`_, `#516`_, `#522`_, `#554`_ and `#560`_ (thanks `@sandilsranasinghe`_),
- `#564`_, `#565`_
+ `#564`_, `#565`_, `#615`_
🧰 Maintenance:
@@ -116,6 +116,7 @@ Upgrade steps from 1.9:
.. _#564: https://github.com/wger-project/wger/issues/564
.. _#565: https://github.com/wger-project/wger/issues/565
.. _#568: https://github.com/wger-project/wger/issues/568
+.. _#615: https://github.com/wger-project/wger/issues/615
diff --git a/wger/exercises/views/exercises.py b/wger/exercises/views/exercises.py
index a849c78f1..f03d97f4f 100644
--- a/wger/exercises/views/exercises.py
+++ b/wger/exercises/views/exercises.py
@@ -202,21 +202,24 @@ class ExerciseForm(ModelForm):
def clean_name_original(self):
"""
- Throws a validation error if the submitted name is too similar to an existing
- exercise's name
+ Throws a validation error if the newly submitted name is too similar to
+ an existing exercise's name
"""
name_original = self.cleaned_data['name_original']
- language = load_language()
- exercises = Exercise.objects.accepted() \
- .filter(language=language)
- for exercise in exercises:
- exercise_name = str(exercise)
- min_edit_dist = levenshtein(exercise_name.casefold(), name_original.casefold())
- if min_edit_dist < MIN_EDIT_DISTANCE_THRESHOLD:
- raise ValidationError(
- _('%(name_original)s is too similar to existing exercise "%(exercise_name)s"'),
- params={'name_original': name_original, 'exercise_name': exercise_name},
- )
+
+ if not self.instance.id:
+ language = load_language()
+ exercises = Exercise.objects.accepted() \
+ .filter(language=language)
+ for exercise in exercises:
+ exercise_name = str(exercise)
+ min_edit_dist = levenshtein(exercise_name.casefold(), name_original.casefold())
+ if min_edit_dist < MIN_EDIT_DISTANCE_THRESHOLD:
+ raise ValidationError(
+ _('%(name_original)s is too similar to existing exercise '
+ '"%(exercise_name)s"'),
+ params={'name_original': name_original, 'exercise_name': exercise_name},
+ )
return name_original