Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Allow only read and update operations to the user profile resource

Roland Geidera776d8ccd294
diff --git a/wger/core/api/serializers.py b/wger/core/api/serializers.py
new file mode 100644
index 000000000..0d679b73e
--- /dev/null
+++ b/wger/core/api/serializers.py
@@ -0,0 +1,29 @@
+# -*- coding: utf-8 -*-
+
+# This file is part of wger Workout Manager.
+#
+# wger Workout Manager is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# wger Workout Manager is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with Workout Manager. If not, see <http://www.gnu.org/licenses/>.
+
+from rest_framework import serializers
+
+from wger.core.models import UserProfile
+
+
+class UserprofileSerializer(serializers.ModelSerializer):
+ '''
+ Workout session serializer
+ '''
+ class Meta:
+ model = UserProfile
+ exclude = ('user',)
diff --git a/wger/core/api/views.py b/wger/core/api/views.py
index 0976225bc..98112e810 100644
--- a/wger/core/api/views.py
+++ b/wger/core/api/views.py
@@ -16,13 +16,15 @@
# along with Workout Manager. If not, see <http://www.gnu.org/licenses/>.
from django.contrib.auth.models import User
-
from rest_framework import viewsets
from wger.core.models import UserProfile
from wger.core.models import Language
from wger.core.models import DaysOfWeek
from wger.core.models import License
+from wger.core.api.serializers import UserprofileSerializer
+from wger.utils.permissions import UpdateOnlyPermission
+from wger.utils.permissions import WgerPermission
class UserProfileViewSet(viewsets.ModelViewSet):
@@ -31,7 +33,8 @@ class UserProfileViewSet(viewsets.ModelViewSet):
'''
model = UserProfile
is_private = True
- ordering_fields = '__all__'
+ serializer_class = UserprofileSerializer
+ permission_classes = (WgerPermission, UpdateOnlyPermission)
def get_queryset(self):
'''
@@ -39,9 +42,6 @@ class UserProfileViewSet(viewsets.ModelViewSet):
'''
return UserProfile.objects.filter(user=self.request.user)
- def create(self, request):
- pass
-
def get_owner_objects(self):
'''
Return objects to check for ownership permission
diff --git a/wger/exercises/api/views.py b/wger/exercises/api/views.py
index c6f809ab6..8abe6765b 100644
--- a/wger/exercises/api/views.py
+++ b/wger/exercises/api/views.py
@@ -35,7 +35,7 @@ from wger.exercises.models import ExerciseImage
from wger.exercises.models import ExerciseComment
from wger.exercises.models import Muscle
from wger.utils.language import load_item_languages
-from wger.utils.permissions import CreateOnly
+from wger.utils.permissions import CreateOnlyPermission
class ExerciseViewSet(viewsets.ModelViewSet):
@@ -43,7 +43,7 @@ class ExerciseViewSet(viewsets.ModelViewSet):
API endpoint for exercise objects
'''
model = Exercise
- permission_classes = (IsAuthenticatedOrReadOnly, CreateOnly)
+ permission_classes = (IsAuthenticatedOrReadOnly, CreateOnlyPermission)
ordering_fields = '__all__'
filter_fields = ('category',
'creation_date',
@@ -127,7 +127,7 @@ class ExerciseImageViewSet(viewsets.ModelViewSet):
API endpoint for exercise image objects
'''
model = ExerciseImage
- permission_classes = (IsAuthenticatedOrReadOnly, CreateOnly)
+ permission_classes = (IsAuthenticatedOrReadOnly, CreateOnlyPermission)
ordering_fields = '__all__'
filter_fields = ('image',
'is_main',
diff --git a/wger/utils/permissions.py b/wger/utils/permissions.py
index 72796c0be..731553f17 100644
--- a/wger/utils/permissions.py
+++ b/wger/utils/permissions.py
@@ -57,7 +57,7 @@ class WgerPermission(permissions.BasePermission):
return False
-class CreateOnly(permissions.BasePermission):
+class CreateOnlyPermission(permissions.BasePermission):
'''
Custom permission that permits read access the resource but limits the
write operations to creating (POSTing) new objects only and does not
@@ -70,3 +70,15 @@ class CreateOnly(permissions.BasePermission):
(request.user and
request.user.is_authenticated() and
request.method == 'POST'))
+
+
+class UpdateOnlyPermission(permissions.BasePermission):
+ '''
+ Custom permission that restricts write operations to PATCH. This is currently
+ used for the user profile.
+ '''
+
+ def has_permission(self, request, view):
+ return (request.user and
+ request.user.is_authenticated() and
+ request.method in ['GET', 'HEAD', 'OPTIONS', 'PATCH'])