Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Allow access to all for safe HTTP methods to exercise endpoints

Roland Geidera85cc1b405dd
diff --git a/wger/exercises/api/permissions.py b/wger/exercises/api/permissions.py
index 341e357e9..2bd92ddaa 100644
--- a/wger/exercises/api/permissions.py
+++ b/wger/exercises/api/permissions.py
@@ -24,11 +24,15 @@ class CanEditExercises(BasePermission):
Regular users that are "trustworthy" (see Userprofile model for details) and
administrator users with the appropriate exercise permission are allowed.
"""
+ SAFE_METHODS = ['GET', 'HEAD', 'OPTIONS']
def has_permission(self, request, view):
- if request.user.is_anonymous:
- return False
+ # Everybody can read
+ if request.method in self.SAFE_METHODS:
+ return True
+
+ # Only "trustworthy" users can edit
return (
request.user.userprofile.is_trustworthy
or request.user.has_perm('exercises.add_exercise')
diff --git a/wger/exercises/api/views.py b/wger/exercises/api/views.py
index a16e448af..5848d5793 100644
--- a/wger/exercises/api/views.py
+++ b/wger/exercises/api/views.py
@@ -73,7 +73,7 @@ class ExerciseBaseViewSet(CreateUpdateModelViewSet):
"""
queryset = ExerciseBase.objects.accepted()
serializer_class = ExerciseBaseSerializer
- permission_classes = (IsAuthenticatedOrReadOnly, ) #CanEditExercises
+ permission_classes = (CanEditExercises, )
ordering_fields = '__all__'
filterset_fields = (
'category',
@@ -88,6 +88,7 @@ class ExerciseViewSet(viewsets.ReadOnlyModelViewSet): #viewsets.ReadOnlyModelVie
the information of an exercise, see /api/v2/exerciseinfo/
"""
queryset = Exercise.objects.accepted()
+ permission_classes = (CanEditExercises,)
serializer_class = ExerciseSerializer
ordering_fields = '__all__'
filterset_fields = (