Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Improve some of the queries used for the api endpoint

Roland Geiderb2d925ef6c50
diff --git a/wger/nutrition/api/views.py b/wger/nutrition/api/views.py
index 664f8200c..5e1091b15 100644
--- a/wger/nutrition/api/views.py
+++ b/wger/nutrition/api/views.py
@@ -143,6 +143,15 @@ class IngredientInfoViewSet(IngredientViewSet):
serializer_class = IngredientInfoSerializer
+ def get_queryset(self):
+ """Optimize the queryset with select_related to avoid n+1 queries"""
+
+ return Ingredient.objects.select_related(
+ 'language',
+ 'license',
+ 'image',
+ )
+
@api_view(['GET'])
def search(request):
@@ -211,7 +220,6 @@ class ImageViewSet(viewsets.ReadOnlyModelViewSet):
API endpoint for ingredient images
"""
- queryset = Image.objects.all()
serializer_class = IngredientImageSerializer
ordering_fields = '__all__'
filterset_fields = ('uuid', 'ingredient_id', 'ingredient__uuid')
@@ -220,6 +228,13 @@ class ImageViewSet(viewsets.ReadOnlyModelViewSet):
def dispatch(self, request, *args, **kwargs):
return super().dispatch(request, *args, **kwargs)
+ def get_queryset(self):
+ """Optimize the queryset"""
+
+ return Image.objects.select_related(
+ 'ingredient'
+ )
+
class WeightUnitViewSet(viewsets.ReadOnlyModelViewSet):
"""