Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

fix(manager): preserve workout history when deleting routine structure

Bee minesb367a57e4881
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ff9145f13..83b122431 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,21 +5,28 @@
## New features
-
### Others
-*
+
+<!-- Add other changes here. -->
### Bug fixes
-*
+* Deleting a routine, day, slot, or slot entry now preserves completed workout
+ sessions and logs, including performed and target values. Only the references
+ to deleted routine structure are cleared. Explicit session deletion and account
+ deletion continue to remove the corresponding history. Apply the usual database
+ migrations when upgrading; previously deleted history cannot be restored by
+ this change.
## New settings
-*(for self-hoster)*
-*
+(for self-hoster)
+
+<!-- Add new settings here. -->
## Breaking API changes
-*(only relevant if you have your own scripts or interact with the REST API)*
+
+(only relevant if you have your own scripts or interact with the REST API)
* Creating exercises via `POST /api/v2/exercise/` now requires the `add_exercise`
permission. Regular users should use `/api/v2/exercise-submission/`, which
diff --git a/wger/manager/migrations/0030_preserve_workout_history.py b/wger/manager/migrations/0030_preserve_workout_history.py
new file mode 100644
index 000000000..4787d3935
--- /dev/null
+++ b/wger/manager/migrations/0030_preserve_workout_history.py
@@ -0,0 +1,47 @@
+# Generated by Django 6.0.8 on 2026-09-26 07:52
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+ dependencies = [
+ ('manager', '0029_alter_workoutsession_options_and_more'),
+ ]
+
+ operations = [
+ migrations.AlterField(
+ model_name='workoutlog',
+ name='routine',
+ field=models.ForeignKey(
+ null=True,
+ on_delete=django.db.models.deletion.SET_NULL,
+ to='manager.routine',
+ verbose_name='Workout',
+ ),
+ ),
+ migrations.AlterField(
+ model_name='workoutlog',
+ name='slot_entry',
+ field=models.ForeignKey(
+ null=True, on_delete=django.db.models.deletion.SET_NULL, to='manager.slotentry'
+ ),
+ ),
+ migrations.AlterField(
+ model_name='workoutsession',
+ name='day',
+ field=models.ForeignKey(
+ null=True, on_delete=django.db.models.deletion.SET_NULL, to='manager.day'
+ ),
+ ),
+ migrations.AlterField(
+ model_name='workoutsession',
+ name='routine',
+ field=models.ForeignKey(
+ null=True,
+ on_delete=django.db.models.deletion.SET_NULL,
+ related_name='sessions',
+ to='manager.routine',
+ ),
+ ),
+ ]
diff --git a/wger/manager/models/log.py b/wger/manager/models/log.py
index 137fb0471..5ef8c8c35 100644
--- a/wger/manager/models/log.py
+++ b/wger/manager/models/log.py
@@ -104,13 +104,13 @@ class WorkoutLog(models.Model):
routine = models.ForeignKey(
'Routine',
verbose_name='Workout',
- on_delete=models.CASCADE,
+ on_delete=models.SET_NULL,
null=True,
)
slot_entry = models.ForeignKey(
'SlotEntry',
- on_delete=models.CASCADE,
+ on_delete=models.SET_NULL,
null=True,
)
diff --git a/wger/manager/models/session.py b/wger/manager/models/session.py
index 7b3bf702f..879966388 100644
--- a/wger/manager/models/session.py
+++ b/wger/manager/models/session.py
@@ -68,14 +68,14 @@ class WorkoutSession(models.Model):
routine = models.ForeignKey(
'Routine',
- on_delete=models.CASCADE,
+ on_delete=models.SET_NULL,
related_name='sessions',
null=True,
)
day = models.ForeignKey(
'Day',
- on_delete=models.CASCADE,
+ on_delete=models.SET_NULL,
null=True,
)
"""
diff --git a/wger/manager/tests/test_history_retention.py b/wger/manager/tests/test_history_retention.py
new file mode 100644
index 000000000..8d83faa04
--- /dev/null
+++ b/wger/manager/tests/test_history_retention.py
@@ -0,0 +1,135 @@
+# This file is part of wger Workout Manager.
+#
+# wger Workout Manager is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# Standard Library
+import datetime
+from decimal import Decimal
+
+# Django
+from django.contrib.auth.models import User
+from django.urls import reverse
+
+# Third Party
+from rest_framework import status
+
+# wger
+from wger.core.tests.base_testcase import WgerTestCase, get_field_snapshot
+from wger.manager.models import Day, Routine, Slot, SlotEntry, WorkoutLog, WorkoutSession
+
+
+class WorkoutHistoryRetentionTestCase(WgerTestCase):
+ def setUp(self):
+ super().setUp()
+ self.user_login('test')
+ self.owner = User.objects.get(username='test')
+ self.routine = Routine.objects.create(
+ user=self.owner,
+ name='History retention',
+ start=datetime.date(2026, 1, 1),
+ end=datetime.date(2026, 2, 1),
+ )
+ self.day = Day.objects.create(routine=self.routine, name='Training day')
+ self.slot = Slot.objects.create(day=self.day)
+ self.entry = SlotEntry.objects.create(slot=self.slot, exercise_id=1)
+ self.session = WorkoutSession.objects.create(
+ user=self.owner, routine=self.routine, day=self.day
+ )
+ self.log = WorkoutLog.objects.create(
+ user=self.owner,
+ exercise_id=1,
+ routine=self.routine,
+ slot_entry=self.entry,
+ session=self.session,
+ iteration=1,
+ weight=Decimal('25'),
+ weight_target=Decimal('30'),
+ repetitions=8,
+ repetitions_target=10,
+ )
+
+ def assert_history_preserved(
+ self, endpoint, instance, *, routine_deleted=False, day_deleted=False
+ ):
+ log_values = get_field_snapshot(self.log)
+ session_values = get_field_snapshot(self.session)
+ log_count = WorkoutLog.objects.count()
+ session_count = WorkoutSession.objects.count()
+ response = self.client.delete(reverse(endpoint, kwargs={'pk': instance.pk}))
+ self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT, response.content)
+ self.assertFalse(type(instance).objects.filter(pk=instance.pk).exists())
+
+ self.log.refresh_from_db()
+ self.session.refresh_from_db()
+ log_values['slot_entry_id'] = None
+ if routine_deleted:
+ log_values['routine_id'] = None
+ session_values['routine_id'] = None
+ if day_deleted:
+ session_values['day_id'] = None
+ self.assertEqual(get_field_snapshot(self.log), log_values)
+ self.assertEqual(get_field_snapshot(self.session), session_values)
+ self.assertEqual(WorkoutLog.objects.count(), log_count)
+ self.assertEqual(WorkoutSession.objects.count(), session_count)
+
+ for name, obj in [('workoutlog-detail', self.log), ('workoutsession-detail', self.session)]:
+ response = self.client.get(reverse(name, kwargs={'pk': obj.pk}))
+ self.assertEqual(response.status_code, status.HTTP_200_OK, response.content)
+ self.assertEqual(
+ response.json()['routine'], None if routine_deleted else self.routine.pk
+ )
+
+ def test_delete_slot_entry_preserves_history(self):
+ self.assert_history_preserved('slot-entry-detail', self.entry)
+
+ def test_delete_slot_preserves_history(self):
+ self.assert_history_preserved('slot-detail', self.slot)
+
+ def test_delete_day_preserves_history(self):
+ self.assert_history_preserved('day-detail', self.day, day_deleted=True)
+
+ def test_delete_routine_preserves_history(self):
+ self.assert_history_preserved(
+ 'routine-detail', self.routine, routine_deleted=True, day_deleted=True
+ )
+
+ def test_bulk_delete_routine_preserves_history(self):
+ Routine.objects.filter(pk=self.routine.pk).delete()
+ self.log.refresh_from_db()
+ self.session.refresh_from_db()
+ self.assertIsNone(self.log.routine_id)
+ self.assertIsNone(self.log.slot_entry_id)
+ self.assertIsNone(self.session.routine_id)
+ self.assertIsNone(self.session.day_id)
+ self.assertEqual(self.log.session_id, self.session.pk)
+
+ def test_foreign_user_cannot_delete_routine_or_read_retained_history(self):
+ self.user_login('admin')
+ response = self.client.delete(reverse('routine-detail', kwargs={'pk': self.routine.pk}))
+ self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
+ self.assertTrue(Routine.objects.filter(pk=self.routine.pk).exists())
+
+ self.routine.delete()
+ self.assertTrue(WorkoutLog.objects.filter(pk=self.log.pk).exists())
+ for endpoint, obj in [
+ ('workoutlog-detail', self.log),
+ ('workoutsession-detail', self.session),
+ ]:
+ response = self.client.get(reverse(endpoint, kwargs={'pk': obj.pk}))
+ self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
+
+ def test_explicit_session_deletion_still_removes_its_logs(self):
+ response = self.client.delete(
+ reverse('workoutsession-detail', kwargs={'pk': self.session.pk})
+ )
+ self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
+ self.assertFalse(WorkoutLog.objects.filter(pk=self.log.pk).exists())
+ self.assertTrue(Routine.objects.filter(pk=self.routine.pk).exists())
+
+ def test_account_deletion_still_removes_history(self):
+ self.owner.delete()
+ self.assertFalse(WorkoutLog.objects.filter(pk=self.log.pk).exists())
+ self.assertFalse(WorkoutSession.objects.filter(pk=self.session.pk).exists())