Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Enforce the permission on the gym admin config edit view

Roland Geiderd0ca31ca89be
diff --git a/wger/gym/tests/test_admin_config.py b/wger/gym/tests/test_admin_config.py
index 62fd6222f..5c7ec036e 100644
--- a/wger/gym/tests/test_admin_config.py
+++ b/wger/gym/tests/test_admin_config.py
@@ -12,8 +12,15 @@
#
# You should have received a copy of the GNU Affero General Public License
+# Django
+from django.contrib.auth.models import User
+from django.urls import reverse
+
# wger
-from wger.core.tests.base_testcase import WgerEditTestCase
+from wger.core.tests.base_testcase import (
+ WgerEditTestCase,
+ WgerTestCase,
+)
from wger.gym.models import GymAdminConfig
@@ -35,3 +42,36 @@ class EditConfigTestCase(WgerEditTestCase):
'general_manager2',
)
data = {'overview_inactive': False}
+
+
+class EditConfigPermissionTestCase(WgerTestCase):
+ """
+ Editing the own admin config needs the change_gymadminconfig permission
+ """
+
+ def url(self):
+ return reverse('gym:admin_config:edit', kwargs={'pk': 4})
+
+ def test_owner_with_permission(self):
+ """
+ A trainer can edit their own config
+ """
+ self.user_login('trainer1')
+ response = self.client.post(self.url(), {'overview_inactive': ''})
+
+ self.assertEqual(response.status_code, 302)
+ self.assertFalse(GymAdminConfig.objects.get(pk=4).overview_inactive)
+
+ def test_owner_without_permission(self):
+ """
+ Owning the config is not enough without the permission
+ """
+ user = User.objects.get(username='trainer1')
+ user.groups.clear()
+ user.user_permissions.clear()
+
+ self.user_login('trainer1')
+ response = self.client.post(self.url(), {'overview_inactive': ''})
+
+ self.assertEqual(response.status_code, 403)
+ self.assertTrue(GymAdminConfig.objects.get(pk=4).overview_inactive)
diff --git a/wger/gym/views/admin_config.py b/wger/gym/views/admin_config.py
index 80846ed00..00de7edfb 100644
--- a/wger/gym/views/admin_config.py
+++ b/wger/gym/views/admin_config.py
@@ -27,13 +27,16 @@ from django.views.generic import UpdateView
# wger
from wger.gym.models import GymAdminConfig
-from wger.utils.generic_views import WgerFormMixin
+from wger.utils.generic_views import (
+ WgerFormMixin,
+ WgerPermissionMixin,
+)
logger = logging.getLogger(__name__)
-class ConfigUpdateView(WgerFormMixin, UpdateView):
+class ConfigUpdateView(WgerPermissionMixin, WgerFormMixin, UpdateView):
"""
View to update an existing admin gym configuration
"""