Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Compare the gym of the config in the gym config edit view

Roland Geiderdd28603abe5b
diff --git a/wger/gym/tests/test_config.py b/wger/gym/tests/test_config.py
index 5b2e994da..dd498821e 100644
--- a/wger/gym/tests/test_config.py
+++ b/wger/gym/tests/test_config.py
@@ -13,8 +13,14 @@
# You should have received a copy of the GNU Affero General Public License
# along with Workout Manager. If not, see <http://www.gnu.org/licenses/>.
+# Django
+from django.urls import reverse
+
# wger
-from wger.core.tests.base_testcase import WgerEditTestCase
+from wger.core.tests.base_testcase import (
+ WgerEditTestCase,
+ WgerTestCase,
+)
from wger.gym.models import GymConfig
@@ -41,3 +47,29 @@ class EditGymConfigTestCase(WgerEditTestCase):
'trainer4',
'manager3',
)
+
+
+class EditGymConfigOwnershipTestCase(WgerTestCase):
+ """
+ Managers can only edit the config of their own gym, also when the ids of the
+ config and the gym differ (config 2 belongs to gym 3 in the fixtures)
+ """
+
+ data = {'weeks_inactive': 99, 'show_name': True}
+
+ def edit(self, config_pk: int) -> int:
+ self.user_login('manager3') # gym 2
+ response = self.client.post(reverse('gym:config:edit', kwargs={'pk': config_pk}), self.data)
+ return response.status_code
+
+ def test_config_of_other_gym(self):
+ self.assertEqual(GymConfig.objects.get(pk=2).gym_id, 3)
+
+ self.assertEqual(self.edit(2), 403)
+ self.assertNotEqual(GymConfig.objects.get(pk=2).weeks_inactive, 99)
+
+ def test_config_of_own_gym(self):
+ self.assertEqual(GymConfig.objects.get(pk=3).gym_id, 2)
+
+ self.assertEqual(self.edit(3), 302)
+ self.assertEqual(GymConfig.objects.get(pk=3).weeks_inactive, 99)
diff --git a/wger/gym/views/config.py b/wger/gym/views/config.py
index 928f81fb3..ad29ae716 100644
--- a/wger/gym/views/config.py
+++ b/wger/gym/views/config.py
@@ -50,7 +50,7 @@ class GymConfigUpdateView(WgerFormMixin, LoginRequiredMixin, PermissionRequiredM
"""
if request.user.has_perm('gym.change_gymconfig'):
gym_id = request.user.userprofile.gym_id
- if gym_id != int(self.kwargs['pk']):
+ if gym_id != self.get_object().gym_id:
return HttpResponseForbidden()
return super(GymConfigUpdateView, self).dispatch(request, *args, **kwargs)