Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Add uniqueness constraint

Roland Geidere4b9bc3a0392
diff --git a/wger/measurements/migrations/0006_category_externally_synced_category_metric_type_and_more.py b/wger/measurements/migrations/0006_category_externally_synced_category_metric_type_and_more.py
index 0eef21a4b..299d0d8ce 100644
--- a/wger/measurements/migrations/0006_category_externally_synced_category_metric_type_and_more.py
+++ b/wger/measurements/migrations/0006_category_externally_synced_category_metric_type_and_more.py
@@ -50,4 +50,12 @@ class Migration(migrations.Migration):
verbose_name='Source',
),
),
+ migrations.AddConstraint(
+ model_name='measurement',
+ constraint=models.UniqueConstraint(
+ condition=models.Q(('external_id__isnull', False)),
+ fields=('category', 'source', 'external_id'),
+ name='unique_external_measurement',
+ ),
+ ),
]
diff --git a/wger/measurements/models/measurement.py b/wger/measurements/models/measurement.py
index 3c8d408d2..a34aa2d88 100644
--- a/wger/measurements/models/measurement.py
+++ b/wger/measurements/models/measurement.py
@@ -37,6 +37,13 @@ class Measurement(models.Model):
ordering = [
'-date',
]
+ constraints = [
+ models.UniqueConstraint(
+ fields=['category', 'source', 'external_id'],
+ condition=models.Q(external_id__isnull=False),
+ name='unique_external_measurement',
+ ),
+ ]
id = models.UUIDField(
default=uuid7,
diff --git a/wger/measurements/tests/test_measurements.py b/wger/measurements/tests/test_measurements.py
index c51dcf45e..fb4707e8e 100644
--- a/wger/measurements/tests/test_measurements.py
+++ b/wger/measurements/tests/test_measurements.py
@@ -12,8 +12,16 @@
#
# You should have received a copy of the GNU Affero General Public License
# along with Workout Manager. If not, see <http://www.gnu.org/licenses/>.
+
+# Django
+from django.db import (
+ IntegrityError,
+ transaction,
+)
+
# wger
from wger.core.tests import api_base_test
+from wger.core.tests.base_testcase import WgerTestCase
from wger.measurements.models import Measurement
@@ -30,3 +38,33 @@ class MeasurementsApiTestCase(api_base_test.ApiBaseResourceTestCase):
'date': '2021-08-12',
'value': 99.99,
}
+
+
+class ExternalMeasurementConstraintTestCase(WgerTestCase):
+ """
+ The (category, source, external_id) uniqueness that keeps re-imports idempotent.
+ """
+
+ category_id = 'cccccccc-cccc-cccc-cccc-000000000002'
+ external_id = 'eeeeeeee-eeee-eeee-eeee-000000000001'
+
+ def _create(self, **kwargs):
+ defaults = {
+ 'category_id': self.category_id,
+ 'value': 42,
+ 'source': 'apple',
+ 'external_id': self.external_id,
+ }
+ defaults.update(kwargs)
+ return Measurement.objects.create(**defaults)
+
+ def test_duplicate_external_record_rejected(self):
+ self._create()
+ with self.assertRaises(IntegrityError), transaction.atomic():
+ self._create()
+
+ def test_null_external_id_allows_duplicates(self):
+ before = Measurement.objects.count()
+ self._create(external_id=None)
+ self._create(external_id=None)
+ self.assertEqual(Measurement.objects.count(), before + 2)