Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Self review changes

Tom Bowyerefef8151f2ff
diff --git a/wger/core/tests/api_base_test.py b/wger/core/tests/api_base_test.py
index 7a90e2224..6946b9ff9 100644
--- a/wger/core/tests/api_base_test.py
+++ b/wger/core/tests/api_base_test.py
@@ -160,7 +160,7 @@ class ApiGetTestCase(object):
def test_get_overview_is_cached(self):
"""
- Test accessing the overview view of a resource
+ Test accessing the overview view of a resource is cached
"""
# Ensure the wger cache is empty.
cache_length = len(locmem._caches['wger-cache'])
diff --git a/wger/exercises/api/views.py b/wger/exercises/api/views.py
index 41a0275cf..b536a3018 100644
--- a/wger/exercises/api/views.py
+++ b/wger/exercises/api/views.py
@@ -67,7 +67,7 @@ from wger.utils.permissions import CreateOnlyPermission
logger = logging.getLogger(__name__)
-exerciseCacheTTL = 60 * 60 # One hour
+exercise_cache_TTL = 60 * 60 # One hour
class ExerciseBaseViewSet(viewsets.ReadOnlyModelViewSet):
"""
@@ -105,7 +105,7 @@ class ExerciseViewSet(viewsets.ReadOnlyModelViewSet):
'name',
)
- @method_decorator(cache_page(exerciseCacheTTL))
+ @method_decorator(cache_page(exercise_cache_TTL))
def dispatch(self, request, *args, **kwargs):
return super().dispatch(request, *args, **kwargs)
@@ -229,7 +229,7 @@ class ExerciseInfoViewset(viewsets.ReadOnlyModelViewSet):
'license_author',
)
- @method_decorator(cache_page(exerciseCacheTTL))
+ @method_decorator(cache_page(exercise_cache_TTL))
def dispatch(self, request, *args, **kwargs):
return super().dispatch(request, *args, **kwargs)
@@ -253,7 +253,7 @@ class ExerciseBaseInfoViewset(viewsets.ReadOnlyModelViewSet):
'license_author',
)
- @method_decorator(cache_page(exerciseCacheTTL))
+ @method_decorator(cache_page(exercise_cache_TTL))
def dispatch(self, request, *args, **kwargs):
return super().dispatch(request, *args, **kwargs)
diff --git a/wger/exercises/tests/test_exercise.py b/wger/exercises/tests/test_exercise.py
index 8241ee927..694b615cc 100644
--- a/wger/exercises/tests/test_exercise.py
+++ b/wger/exercises/tests/test_exercise.py
@@ -18,7 +18,6 @@ import json
# Django
from django.core import mail
from django.core.cache import cache
-from django.core.cache.backends import locmem
from django.core.cache.utils import make_template_fragment_key
from django.template import (
Context,
@@ -26,9 +25,6 @@ from django.template import (
)
from django.urls import reverse
-# Third Party
-from rest_framework import status
-
# wger
from wger.core.tests import api_base_test
from wger.core.tests.base_testcase import (