Self hosted FLOSS fitness/workout, nutrition and weight tracker
Add tests and authorization checks for gym mass-email
Roland Geiderf3c0932a9558
diff --git a/wger/mailer/tests/test_gym_emails.py b/wger/mailer/tests/test_gym_emails.pyindex e91729319..ab2a2da4e 100644--- a/wger/mailer/tests/test_gym_emails.py+++ b/wger/mailer/tests/test_gym_emails.py@@ -13,10 +13,18 @@# You should have received a copy of the GNU Affero General Public License# Django+from django.core import mailfrom django.urls import reverse# wger-from wger.core.tests.base_testcase import WgerAccessTestCase+from wger.core.tests.base_testcase import (+ WgerAccessTestCase,+ WgerTestCase,+)+from wger.mailer.models import (+ CronEntry,+ Log,+)class AccessContractTestCase(WgerAccessTestCase):@@ -38,3 +46,83 @@ class AccessContractTestCase(WgerAccessTestCase):'member4','member5',)+++class EmailListFormPreviewTestCase(WgerTestCase):+ """+ Tests authorization on the gym mass-email FormPreview (both stages).+ """++ def setUp(self):+ super().setUp()+ self.url = reverse('email:email:add-gym', kwargs={'gym_pk': 1})++ def test_preview_stage_rejects_unauthorized(self):+ """+ Stage 1 must reject unauthorized callers before process_preview()+ runs — otherwise the preview email is sent regardless.+ """+ # Anonymous+ response = self.client.post(+ self.url,+ {'stage': '1', 'subject': 'Spam subject', 'body': 'Spam body'},+ )+ self.assertEqual(response.status_code, 403)++ # A logged-in user without the mailer permission+ self.user_login('member1')+ response = self.client.post(+ self.url,+ {'stage': '1', 'subject': 'Spam subject', 'body': 'Spam body'},+ )+ self.assertEqual(response.status_code, 403)++ # No preview email was sent in either case+ self.assertEqual(len(mail.outbox), 0)++ def test_send_stage_rejects_cross_gym_hash_replay(self):+ """+ The formtools security hash only covers the form fields, not the gym.+ A valid hash obtained for one gym must not let done() run against+ another gym.+ """+ # manager1 legitimately previews for their own gym (gym 1) -> valid hash+ self.user_login('manager1')+ preview = self.client.post(+ self.url,+ {'stage': '1', 'subject': 'Hello', 'body': 'Hello body'},+ )+ self.assertEqual(preview.status_code, 200)+ hash_value = preview.context['hash_value']++ # ...then replays stage 2 with that hash against gym 2+ log_count = Log.objects.count()+ cron_count = CronEntry.objects.count()+ cross_gym_url = reverse('email:email:add-gym', kwargs={'gym_pk': 2})+ response = self.client.post(+ cross_gym_url,+ {'stage': '2', 'hash': hash_value, 'subject': 'Hello', 'body': 'Hello body'},+ )++ self.assertEqual(response.status_code, 403)+ self.assertEqual(Log.objects.count(), log_count)+ self.assertEqual(CronEntry.objects.count(), cron_count)++ def test_authorized_manager_can_preview_and_send(self):+ """The happy path still works: a gym manager can preview and queue emails."""+ self.user_login('manager1')++ preview = self.client.post(+ self.url,+ {'stage': '1', 'subject': 'Hello', 'body': 'Hello body'},+ )+ self.assertEqual(preview.status_code, 200)+ hash_value = preview.context['hash_value']++ log_count = Log.objects.count()+ response = self.client.post(+ self.url,+ {'stage': '2', 'hash': hash_value, 'subject': 'Hello', 'body': 'Hello body'},+ )+ self.assertEqual(response.status_code, 302)+ self.assertEqual(Log.objects.count(), log_count + 1)diff --git a/wger/mailer/views/gym.py b/wger/mailer/views/gym.pyindex b1b400f1a..666b294fc 100644--- a/wger/mailer/views/gym.py+++ b/wger/mailer/views/gym.py@@ -18,6 +18,7 @@from django.conf import settingsfrom django.contrib.auth.mixins import PermissionRequiredMixinfrom django.core import mail+from django.core.exceptions import PermissionDeniedfrom django.http import (HttpResponseForbidden,HttpResponseRedirect,@@ -82,26 +83,23 @@ class EmailListFormPreview(FormPreview):list_type = Nonegym = None- def parse_params(self, *args, **kwargs):+ def parse_params(self, request, *args, **kwargs):"""- Save the current recipient type+ Resolve the target gym and enforce authorization."""self.gym = get_object_or_404(Gym, pk=int(kwargs['gym_pk']))- def get_context(self, request, form):- """- Context for template rendering-- Also, check for permissions here. While it is ugly and doesn't really- belong here, it seems it's the best way to do it in a FormPreview- """if (not request.user.is_authenticatedor request.user.userprofile.gym_id != self.gym.idor not request.user.has_perm('mailer.change_log')):- return HttpResponseForbidden()+ raise PermissionDenied+ def get_context(self, request, form):+ """+ Context for template rendering+ """context = super(EmailListFormPreview, self).get_context(request, form)context['gym'] = self.gymreturn context