Skip to content

armgit / wger

Public Imported from GitHub
0

Self hosted FLOSS fitness/workout, nutrition and weight tracker

Don't fire the trophy signals when loading fixtures

Roland Geiderf93229c24cb2
diff --git a/wger/trophies/signals.py b/wger/trophies/signals.py
index e11577aa0..3a42e107a 100644
--- a/wger/trophies/signals.py
+++ b/wger/trophies/signals.py
@@ -44,6 +44,7 @@ from wger.trophies.models.user_trophy import UserTrophy
from wger.trophies.services import UserStatisticsService
from wger.trophies.services.trophy import TrophyService
from wger.trophies.tasks import evaluate_user_trophies_task
+from wger.utils.helpers import disable_for_loaddata
logger = logging.getLogger(__name__)
@@ -86,6 +87,7 @@ def _trigger_trophy_evaluation(user_id: int):
@receiver(post_save, sender=WorkoutLog)
+@disable_for_loaddata
def workout_log_saved(sender, instance: WorkoutLog, created: bool, **kwargs):
"""
Handle WorkoutLog save events.
@@ -155,6 +157,7 @@ def workout_log_deleted(sender, instance: WorkoutLog, origin=None, **kwargs):
@receiver(post_save, sender=WorkoutSession)
+@disable_for_loaddata
def workout_session_saved(sender, instance: WorkoutSession, created: bool, **kwargs):
"""
Handle WorkoutSession save events.
diff --git a/wger/trophies/tests/test_integration.py b/wger/trophies/tests/test_integration.py
index f5b9ac9e1..1ba674371 100644
--- a/wger/trophies/tests/test_integration.py
+++ b/wger/trophies/tests/test_integration.py
@@ -34,6 +34,10 @@ from wger.trophies.models import (
)
from wger.trophies.services.statistics import UserStatisticsService
from wger.trophies.services.trophy import TrophyService
+from wger.trophies.signals import (
+ workout_log_saved,
+ workout_session_saved,
+)
class TrophyIntegrationTestCase(WgerTestCase):
@@ -474,3 +478,53 @@ class UserDeletionTestCase(WgerTestCase):
self.assertFalse(User.objects.filter(pk=user_id).exists())
self.assertFalse(UserStatistics.objects.filter(user_id=user_id).exists())
+
+
+class LoadDataSignalGuardTestCase(WgerTestCase):
+ """
+ Fixture loading (loaddata) fires post_save with raw=True. The trophy and
+ statistics side effects must be skipped on those raw saves.
+ """
+
+ def setUp(self):
+ super().setUp()
+ self.user = User.objects.get(username='admin')
+ self.exercise = Exercise.objects.create(
+ category=ExerciseCategory.objects.create(name='raw_cat')
+ )
+
+ Trophy.objects.all().delete()
+ Trophy.objects.create(
+ name='Personal Record',
+ trophy_type=Trophy.TYPE_OTHER,
+ checker_class='personal_record',
+ checker_params={},
+ is_active=True,
+ is_repeatable=True,
+ )
+
+ def test_raw_workout_log_save_skips_trophy_and_statistics(self):
+ """A raw WorkoutLog save awards no trophy and creates no statistics row"""
+ log = WorkoutLog.objects.create(
+ user=self.user, exercise=self.exercise, repetitions=10, weight=100
+ )
+
+ # Discard side effects produced by the normal (non-raw) create above.
+ UserTrophy.objects.filter(user=self.user).delete()
+ UserStatistics.objects.filter(user=self.user).delete()
+
+ # Replay the save as loaddata would: raw=True.
+ workout_log_saved(sender=WorkoutLog, instance=log, created=True, raw=True)
+
+ self.assertFalse(UserTrophy.objects.filter(user=self.user).exists())
+ self.assertFalse(UserStatistics.objects.filter(user=self.user).exists())
+
+ def test_raw_workout_session_save_skips_statistics(self):
+ """A raw WorkoutSession save creates no statistics row"""
+ session = WorkoutSession.objects.create(user=self.user, date=datetime.date(2024, 1, 1))
+
+ UserStatistics.objects.filter(user=self.user).delete()
+
+ workout_session_saved(sender=WorkoutSession, instance=session, created=True, raw=True)
+
+ self.assertFalse(UserStatistics.objects.filter(user=self.user).exists())