Worktrunk is a CLI for Git worktree management, designed for parallel AI agent workflows
fix: pr-review skill pre-flight jq escaping and LGTM dedup bug (#1153)
worktrunk-bot3286106f4ff2
diff --git a/.claude/skills/pr-review/SKILL.md b/.claude/skills/pr-review/SKILL.mdindex 30fa4080c..cc9bcc613 100644--- a/.claude/skills/pr-review/SKILL.md+++ b/.claude/skills/pr-review/SKILL.md@@ -26,9 +26,11 @@ BOT_LOGIN=$(gh api user --jq '.login')HEAD_SHA=$(gh pr view <number> --json commits --jq '.commits[-1].oid')-# Find the bot's most recent substantive review (any state)+# Find the bot's most recent substantive review (any state).+# Include reviews with a non-empty body OR approvals (LGTM uses --approve -b "").+# Uses "| length > 0" instead of "!= \"\"" to avoid bash ! history expansion.LAST_REVIEW_SHA=$(gh pr view <number> --json reviews \- --jq "[.reviews[] | select(.author.login == \"$BOT_LOGIN\" and .body != \"\")] | last | .commit.oid // empty")+ --jq "[.reviews[] | select(.author.login == \"$BOT_LOGIN\" and (.body | length > 0 or .state == \"APPROVED\"))] | last | .commit.oid // empty")```If `LAST_REVIEW_SHA == HEAD_SHA`, this commit has already been reviewed — exit@@ -58,7 +60,7 @@ REPO=$(gh repo view --json nameWithOwner --jq '.nameWithOwner')BOT_LOGIN=$(gh api user --jq '.login')# Previous review bodiesgh api "repos/$REPO/pulls/<number>/reviews" \- --jq ".[] | select(.user.login == \"$BOT_LOGIN\" and .body != \"\") | {state, body}"+ --jq ".[] | select(.user.login == \"$BOT_LOGIN\" and (.body | length > 0)) | {state, body}"# Inline review commentsgh api "repos/$REPO/pulls/<number>/comments" --paginate \--jq ".[] | select(.user.login == \"$BOT_LOGIN\") | {path, line, body}"@@ -185,10 +187,14 @@ If nothing is actionable, use the LGTM behavior (approve with empty body).After reviewing, check CI status and decide:```bash+PR_AUTHOR=$(gh pr view <number> --json author --jq '.author.login')gh pr view <number> --json statusCheckRollup \--jq '.statusCheckRollup[] | {name: .name, status: .status, conclusion: .conclusion}'```+**Self-authored PRs:** If `PR_AUTHOR == BOT_LOGIN`, you cannot approve — GitHub+rejects self-approvals. Skip directly to submitting as COMMENT.+- **Confident** (small, mechanical, well-tested): Approve immediately.- **Moderately confident** (non-trivial but looks correct): Approve if CI isgreen. If CI is pending, submit as COMMENT — don't approve unverified changes.@@ -203,7 +209,9 @@ paths decrease it.#### PostingSubmit **one formal review per run** via `gh pr review`. Never call it multiple-times.+times. Note that `--comment` requires a non-empty body (`-b ""`+fails) — if you have nothing to say, use LGTM behavior (`--approve -b ""`)+instead. Never fall back from a failed `--comment` to `--approve`.- Always give a verdict: **approve** or **comment**. Don't use "request changes"(that implies authority to block).