Skip to content

Worktrunk is a CLI for Git worktree management, designed for parallel AI agent workflows

fix(release): stop double-zipping the SignPath upload artifact (#3566)

Maximilian Roos7b741d07917e
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 7f24714d5..791359351 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -159,7 +159,16 @@ jobs:
continue-on-error: true
uses: actions/upload-artifact@v7
with:
- name: unsigned-windows-zip
+ # actions/upload-artifact always wraps the upload in its own
+ # storage zip unless archive: false — since the file we're
+ # uploading is already a zip, the default produced a zip-of-a-zip
+ # that SignPath saw as "the artifact", so the configured
+ # <pe-file path="wt.exe"> never matched (confirmed via a real
+ # signing-request failure: "Expected path to match exactly 1
+ # item, but found 0", processing unsigned-windows-zip.zip).
+ # archive: false uploads the file as-is; the artifact name then
+ # becomes the file's own name, so `name:` here is ignored.
+ archive: false
path: target/distrib/worktrunk-x86_64-pc-windows-msvc.zip
- name: Submit SignPath signing request
if: contains(matrix.targets, 'x86_64-pc-windows-msvc') && steps.upload-unsigned-windows-artifact.outcome == 'success'
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c77b2c42b..cd1dc9f65 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -34,7 +34,7 @@
### Internal
-- **Windows release binaries are submitted to SignPath for code signing**: Signed with a test certificate for now, while the project's OSS-program application is under review, and non-blocking so a signing failure can't hold up publishing to crates.io, Homebrew, winget, or AUR. ([#3553](https://github.com/max-sixty/worktrunk/pull/3553), [#3556](https://github.com/max-sixty/worktrunk/pull/3556))
+- **Windows release binaries are submitted to SignPath for code signing**: Submitted for signing under a test certificate for now, while the project's OSS-program application is under review, and non-blocking so a signing failure can't hold up publishing to crates.io, Homebrew, winget, or AUR. ([#3553](https://github.com/max-sixty/worktrunk/pull/3553), [#3556](https://github.com/max-sixty/worktrunk/pull/3556), [#3566](https://github.com/max-sixty/worktrunk/pull/3566))
- **`wt list` runs its merge analysis in a read-only object database**: When the git object store is read-only, `wt list` and `wt list statusline` redirect their object-writing merge/conflict probes into a temporary object database layered over the real one, so the full analysis still runs. Mutating commands keep the persistent store and fail loudly on a read-only one. ([#3535](https://github.com/max-sixty/worktrunk/pull/3535))