Skip to content

Worktrunk is a CLI for Git worktree management, designed for parallel AI agent workflows

fix(plugin): add pipefail to WorktreeCreate hook so wt failures surface (#3546)

Worktrunk Botdbefb98ed4c8
diff --git a/plugins/worktrunk/hooks/hooks.json b/plugins/worktrunk/hooks/hooks.json
index d1f1df135..babae7b44 100644
--- a/plugins/worktrunk/hooks/hooks.json
+++ b/plugins/worktrunk/hooks/hooks.json
@@ -69,7 +69,7 @@
"hooks": [
{
"type": "command",
- "command": "bash -c 'name=$(jq -er .name) || exit 1; cd \"${CLAUDE_PROJECT_DIR:-.}\" || exit 1; bash \"$CLAUDE_PLUGIN_ROOT/hooks/wt.sh\" switch --create \"$name\" --no-cd --format=json | jq -er .path'"
+ "command": "bash -c 'set -o pipefail; name=$(jq -er .name) || exit 1; cd \"${CLAUDE_PROJECT_DIR:-.}\" || exit 1; bash \"$CLAUDE_PLUGIN_ROOT/hooks/wt.sh\" switch --create \"$name\" --no-cd --format=json | jq -er .path'"
}
]
}
diff --git a/tests/integration_tests/config_show.rs b/tests/integration_tests/config_show.rs
index 13d09626a..a174c0fb5 100644
--- a/tests/integration_tests/config_show.rs
+++ b/tests/integration_tests/config_show.rs
@@ -4275,6 +4275,27 @@ fn test_plugin_layout_is_consolidated() {
hooks.json:\n{hooks}"
);
+ // The WorktreeCreate hook pipes `wt … --format=json | jq -er .path`. Without
+ // `set -o pipefail` the pipeline's exit status is jq's, and `jq -er .path`
+ // on the empty stdout of a failed `wt` exits 0 on jq 1.6 — so a `wt` failure
+ // (e.g. an existing-branch collision after the branch/worktree were already
+ // created) is swallowed and Claude Code reports the misleading "hook
+ // succeeded but returned no worktree path" instead of wt's real error
+ // (#3545). pipefail makes the pipeline surface wt's nonzero exit regardless
+ // of jq version. The wrapper must be `bash -c` (dash rejects `set -o
+ // pipefail` fatally; some login shells are fish, which has no shell options)
+ // — see skills/wt-switch-create/rationale.md, "The hooks.json pipefail wrapper".
+ let worktree_create_cmd = hooks_json["hooks"]["WorktreeCreate"][0]["hooks"][0]["command"]
+ .as_str()
+ .expect("WorktreeCreate hook must define a command");
+ assert!(
+ worktree_create_cmd.contains("set -o pipefail"),
+ "WorktreeCreate hook pipes `wt … | jq -er .path`; without `set -o pipefail` a \
+ failed wt with empty stdout is swallowed (jq 1.6 exits 0 on empty input) and \
+ Claude Code reports \"hook succeeded but returned no worktree path\" instead \
+ of wt's real error (#3545). command:\n{worktree_create_cmd}"
+ );
+
// The product description must not drift across tools. Byte-identical is
// schema-impossible (Codex omits the activity clause, Gemini says
// "extension"), but every manifest shares the canonical opening sentence.