Skip to content

Interactive interface for browsing global, full-resolution satellite imagery

Sanitize Layer Info HTML (#6929)

christof-wittreich4375afb6e28b
diff --git a/package-lock.json b/package-lock.json
index 9bea61032..8b104ca80 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -32,6 +32,7 @@
"coordinate-parser": "^1.0.7",
"copy-to-clipboard": "^4.0.2",
"dom-scroll-into-view": "^2.0.1",
+ "dompurify": "^3.4.14",
"element-resize-detector": "^1.2.4",
"elm-pep": "^1.0.6",
"eslint-plugin-react-hooks": "^7.1.1",
@@ -5329,6 +5330,13 @@
"dev": true,
"license": "MIT"
},
+ "node_modules/@types/trusted-types": {
+ "version": "2.0.7",
+ "resolved": "https://registry.npmjs.org/@types/trusted-types/-/trusted-types-2.0.7.tgz",
+ "integrity": "sha512-ScaPdn1dQczgbl0QFTeTOmVHFULt394XJgOQNoyVhZ6r2vLnMLJfBPd53SB52T/3G36VI1/g2MZaX0cwDuXsfw==",
+ "license": "MIT",
+ "optional": true
+ },
"node_modules/@types/use-sync-external-store": {
"version": "0.0.6",
"license": "MIT"
@@ -8871,6 +8879,15 @@
"url": "https://github.com/fb55/domhandler?sponsor=1"
}
},
+ "node_modules/dompurify": {
+ "version": "3.4.14",
+ "resolved": "https://registry.npmjs.org/dompurify/-/dompurify-3.4.14.tgz",
+ "integrity": "sha512-dVoH9z+MY+C9IilgGCk3YfFqjLi3fChm2OiKJMzh6axrJ5qwxqWaZamgmHrpv22CN/KdbZJuGEGgfQoL00LTdg==",
+ "license": "(MPL-2.0 OR Apache-2.0)",
+ "optionalDependencies": {
+ "@types/trusted-types": "^2.0.7"
+ }
+ },
"node_modules/domutils": {
"version": "3.2.2",
"dev": true,
diff --git a/package.json b/package.json
index 7cd26d4cb..a9ce4b522 100644
--- a/package.json
+++ b/package.json
@@ -180,6 +180,7 @@
"coordinate-parser": "^1.0.7",
"copy-to-clipboard": "^4.0.2",
"dom-scroll-into-view": "^2.0.1",
+ "dompurify": "^3.4.14",
"element-resize-detector": "^1.2.4",
"elm-pep": "^1.0.6",
"eslint-plugin-react-hooks": "^7.1.1",
diff --git a/web/js/components/layer/info/info.js b/web/js/components/layer/info/info.js
index 29a76bd76..0b9239bb8 100644
--- a/web/js/components/layer/info/info.js
+++ b/web/js/components/layer/info/info.js
@@ -1,9 +1,15 @@
import { useState, useEffect } from 'react';
import PropTypes from 'prop-types';
+import DOMPurify from 'dompurify';
import { dateOverlap } from '../../../modules/layers/util';
import DateRanges from './date-ranges';
import { coverageDateFormatter } from '../../../modules/date/util';
+// Keep target attribute for opening links in new tab
+const purifyConfig = {
+ ADD_ATTR: ['target'],
+};
+
export default function LayerInfo ({ layer, measurementDescriptionPath, describeDomainsUrl }) {
const {
dateRanges,
@@ -28,7 +34,7 @@ export default function LayerInfo ({ layer, measurementDescriptionPath, describe
const data = await fetch(`config/metadata/layers/${path}.html`, options);
const metadataHtml = await data.text();
controller = null;
- setFn(metadataHtml || 'No description was found for this layer.');
+ setFn(DOMPurify.sanitize(metadataHtml, purifyConfig) || 'No description was found for this layer.');
} catch (e) {
if (!controller.signal.aborted) {
console.error(e);