Skip to content

Interactive interface for browsing global, full-resolution satellite imagery

WV-4118: Fix spy listener cleanup when switching compare modes (#6769)

vicgonzalez25667c2ec69372
diff --git a/web/js/map/compare/spy.js b/web/js/map/compare/spy.js
index 98d1be381..716c923e7 100644
--- a/web/js/map/compare/spy.js
+++ b/web/js/map/compare/spy.js
@@ -95,7 +95,7 @@ const removeListenersFromLayers = function(layers) {
*/
const removeInverseListenersFromLayers = function(layers) {
lodashEach(layers, (layer) => {
- layer.un('prerender', inverseClip);
+ layer.un('postrender', inverseClip);
layer.un('postrender', restore);
});
};
@@ -170,6 +170,10 @@ export default class Spy {
this.destroy();
this.create(store);
} else {
+ removeListenersFromLayers(topLayers);
+ removeInverseListenersFromLayers(bottomLayers);
+ topLayers.length = 0;
+ bottomLayers.length = 0;
const mapLayers = this.map.getLayers().getArray();
applyEventsToBaseLayers(
mapLayers[0],
@@ -189,6 +193,9 @@ export default class Spy {
this.mapCase.removeChild(label);
removeListenersFromLayers(topLayers);
removeInverseListenersFromLayers(bottomLayers);
+ topLayers.length = 0;
+ bottomLayers.length = 0;
+ mousePosition = null;
}
/**