Skip to content

Enterprise agent platform for building, deploying, and operating AI teammates.

3.1 KB
Raw Blame
"""Tests for the shared ad-hoc engine behind create_db_session (issue #889)."""

import pytest

from xagent.core.storage import manager as storage_manager


@pytest.fixture(autouse=True)
def _reset_adhoc_engine():
    """Isolate the module-level engine cache between tests."""

    def reset():
        engine = storage_manager._adhoc_engine
        storage_manager._adhoc_engine = None
        storage_manager._adhoc_engine_url = None
        if engine is not None:
            engine.dispose()

    reset()
    yield
    reset()


def test_create_db_session_reuses_one_engine(tmp_path, monkeypatch):
    monkeypatch.setenv("DATABASE_URL", f"sqlite:///{tmp_path}/a.db")

    db1 = storage_manager.create_db_session()
    db2 = storage_manager.create_db_session()
    try:
        assert db1.get_bind() is db2.get_bind()
    finally:
        db1.close()
        db2.close()


def test_non_sqlite_engine_uses_configured_pool(monkeypatch):
    """The ad-hoc engine is a SECOND pool in the process; it must honor the
    same XAGENT_DB_POOL_* tunables as the shared web engine. create_all is
    stubbed out so no live PostgreSQL is needed — the assertions only
    concern engine/pool construction."""
    pytest.importorskip("psycopg2")
    monkeypatch.setenv("DATABASE_URL", "postgresql://u:p@localhost:1/nowhere")
    monkeypatch.setenv("XAGENT_DB_POOL_SIZE", "3")
    monkeypatch.setenv("XAGENT_DB_MAX_OVERFLOW", "7")
    monkeypatch.setenv("XAGENT_DB_POOL_TIMEOUT_SECONDS", "11")
    monkeypatch.setattr(
        storage_manager.Base.metadata, "create_all", lambda *a, **k: None
    )

    engine = storage_manager._get_adhoc_engine()
    assert engine.pool.size() == 3
    assert engine.pool._max_overflow == 7
    assert engine.pool._timeout == 11


def test_sqlite_adhoc_engine_hides_bound_parameters(tmp_path, monkeypatch):
    """Same database as the shared web engine (models/database.py) -- a
    commit failure here can bind the same credential-bearing columns
    (OAuth tokens, password hashes) as a query parameter, so this engine
    must hide them too, not just the primary one."""
    monkeypatch.setenv("DATABASE_URL", f"sqlite:///{tmp_path}/a.db")

    db = storage_manager.create_db_session()
    try:
        assert db.get_bind().hide_parameters is True
    finally:
        db.close()


def test_non_sqlite_adhoc_engine_hides_bound_parameters(monkeypatch):
    pytest.importorskip("psycopg2")
    monkeypatch.setenv("DATABASE_URL", "postgresql://u:p@localhost:1/nowhere")
    monkeypatch.setattr(
        storage_manager.Base.metadata, "create_all", lambda *a, **k: None
    )

    engine = storage_manager._get_adhoc_engine()
    assert engine.hide_parameters is True


def test_engine_swaps_when_database_url_changes(tmp_path, monkeypatch):
    monkeypatch.setenv("DATABASE_URL", f"sqlite:///{tmp_path}/a.db")
    db1 = storage_manager.create_db_session()
    bind1 = db1.get_bind()
    db1.close()

    monkeypatch.setenv("DATABASE_URL", f"sqlite:///{tmp_path}/b.db")
    db2 = storage_manager.create_db_session()
    try:
        assert db2.get_bind() is not bind1
    finally:
        db2.close()