Enterprise agent platform for building, deploying, and operating AI teammates.
"""
Unit tests for ``SandboxMountIntent``.
Classification is purely lexical: it compares already-normalized path
strings and never touches the filesystem. These tests pin that behavior,
including the absolute-path precondition and the exact descendant/
ancestor/disjoint split.
"""
from __future__ import annotations
import pytest
from xagent.sandbox.base import SandboxMountIntent
class TestMountIntentNormalization:
def test_normalizes_mount_root(self):
intent = SandboxMountIntent(mount_root="/data/../data2", extra_mounts=())
assert intent.mount_root == "/data2"
def test_normalizes_extra_mounts(self):
intent = SandboxMountIntent(mount_root=None, extra_mounts=("/a/./b", "/a/../c"))
assert intent.extra_mounts == ("/a/b", "/c")
def test_deduplicates_after_normalization(self):
intent = SandboxMountIntent(
mount_root=None,
extra_mounts=("/a/b", "/a/./b", "/a/b"),
)
assert intent.extra_mounts == ("/a/b",)
def test_extra_mounts_are_sorted(self):
intent = SandboxMountIntent(mount_root=None, extra_mounts=("/z", "/a", "/m"))
assert intent.extra_mounts == ("/a", "/m", "/z")
def test_none_mount_root_stays_none(self):
intent = SandboxMountIntent(mount_root=None, extra_mounts=("/a",))
assert intent.mount_root is None
def test_collapses_leading_double_slash(self):
"""``normpath`` alone keeps a leading ``//``, which would make the
lexical prefix comparison read ``//data`` and ``/data/x`` as
unrelated paths."""
intent = SandboxMountIntent(
mount_root="//data", extra_mounts=("//data/x", "/data/y")
)
assert intent.mount_root == "/data"
assert intent.extra_mounts == ("/data/x", "/data/y")
assert intent.covered_extras == ("/data/x", "/data/y")
assert intent.disjoint_extras == ()
class TestMountIntentRejectsUncomparablePaths:
"""Only absolute paths are lexically comparable, so nothing else is accepted.
A relative or empty path normalizes to something like ``"."``, which then
reads as *disjoint* from every absolute extra mount. Disjoint is the
dangerous direction: it grants a path its own mount instead of folding it
into an already-approved root, so this classification feeds allow-list
decisions and must never be silently wrong.
"""
def test_empty_intent_does_not_raise(self):
intent = SandboxMountIntent(mount_root=None, extra_mounts=())
assert intent.mount_root is None
assert intent.extra_mounts == ()
def test_root_equal_to_slash_does_not_raise(self):
intent = SandboxMountIntent(mount_root="/", extra_mounts=("/etc",))
assert intent.mount_root == "/"
def test_relative_mount_root_is_rejected(self):
with pytest.raises(ValueError, match="mount_root must be"):
SandboxMountIntent(mount_root="relative/root", extra_mounts=())
def test_empty_mount_root_is_rejected(self):
"""``canonical_sandbox_path("")`` is ``"."`` -- a silently wrong root."""
with pytest.raises(ValueError, match="mount_root must be"):
SandboxMountIntent(mount_root="", extra_mounts=("/data/x",))
def test_relative_extra_mount_is_rejected(self):
with pytest.raises(ValueError, match="extra_mounts entry must be"):
SandboxMountIntent(mount_root="/data", extra_mounts=("x/y",))
def test_empty_extra_mount_is_rejected(self):
with pytest.raises(ValueError, match="extra_mounts entry must be"):
SandboxMountIntent(mount_root="/data", extra_mounts=("",))
def test_rejection_precedes_any_classification(self):
"""The bad value must never reach a covered/disjoint verdict at all."""
with pytest.raises(ValueError):
SandboxMountIntent(mount_root="", extra_mounts=("/data/x",))
class TestMountIntentClassification:
def test_descendant_is_covered(self):
intent = SandboxMountIntent(mount_root="/data", extra_mounts=("/data/sub",))
assert intent.covered_extras == ("/data/sub",)
assert intent.covering_extras == ()
assert intent.disjoint_extras == ()
def test_equal_path_is_covered(self):
intent = SandboxMountIntent(mount_root="/data", extra_mounts=("/data",))
assert intent.covered_extras == ("/data",)
assert intent.covering_extras == ()
assert intent.disjoint_extras == ()
def test_ancestor_is_covering(self):
intent = SandboxMountIntent(mount_root="/data/sub", extra_mounts=("/data",))
assert intent.covered_extras == ()
assert intent.covering_extras == ("/data",)
assert intent.disjoint_extras == ()
def test_root_of_filesystem_is_covering(self):
intent = SandboxMountIntent(mount_root="/data/sub", extra_mounts=("/",))
assert intent.covering_extras == ("/",)
def test_unrelated_path_is_disjoint(self):
intent = SandboxMountIntent(mount_root="/data", extra_mounts=("/other",))
assert intent.covered_extras == ()
assert intent.covering_extras == ()
assert intent.disjoint_extras == ("/other",)
def test_sibling_with_shared_prefix_is_disjoint_not_covered(self):
# "/database" is not a descendant of "/data" despite the string
# prefix match; classification must respect path-segment boundaries.
intent = SandboxMountIntent(mount_root="/data", extra_mounts=("/database",))
assert intent.covered_extras == ()
assert intent.covering_extras == ()
assert intent.disjoint_extras == ("/database",)
def test_mixed_matrix(self):
intent = SandboxMountIntent(
mount_root="/data",
extra_mounts=("/data/sub", "/data", "/", "/other", "/database"),
)
assert set(intent.covered_extras) == {"/data/sub", "/data"}
assert set(intent.covering_extras) == {"/"}
assert set(intent.disjoint_extras) == {"/other", "/database"}
def test_no_mount_root_means_all_disjoint(self):
intent = SandboxMountIntent(mount_root=None, extra_mounts=("/a", "/b"))
assert intent.covered_extras == ()
assert intent.covering_extras == ()
assert intent.disjoint_extras == ("/a", "/b")