Skip to content

armgit / xerj

Public Imported from GitHub
0

AI search engine and MCP server for bots and agents. One Rust binary indexes code, docs, logs, JSONL/CSV and PDFs for BM25 full-text, vector and hybrid search, code search without grep, agent memory and RAG. Elasticsearch-compatible API; Corpus Hub serves hundreds of reference memory corpora.

fix(mcp): fill version and os in xerj_field_report when the agent omits them (#2005)

xerj-org9ee0cef0ed71
diff --git a/engine/crates/xerj-mcp/src/lib.rs b/engine/crates/xerj-mcp/src/lib.rs
index e40440226..d0f6220d6 100644
--- a/engine/crates/xerj-mcp/src/lib.rs
+++ b/engine/crates/xerj-mcp/src/lib.rs
@@ -1219,15 +1219,15 @@ pub fn tool_specs_with(include_hub: bool) -> Value {
},
"verdict": {
"type": "string",
- "description": "What worked and what did not. Capped at 80 characters on the wire; put the long text in notes."
+ "description": "What worked and what did not, in one or two sentences (up to 1000 characters). Put the long report in notes."
},
"version": {
"type": "string",
- "description": "xerj version, if known. Optional."
+ "description": "xerj version. Optional: when omitted, this binary's own version is sent."
},
"os": {
"type": "string",
- "description": "OS and architecture. Optional."
+ "description": "OS and architecture. Optional: when omitted, this machine's OS and architecture are sent."
},
"indexed": {
"type": "string",
@@ -1325,6 +1325,19 @@ async fn call_field_report(args: &Value) -> Value {
Ok(v) => v,
Err(msg) => return tool_text(msg, true),
};
+ // Fill the facts this process can observe, the same way `xerj feedback`
+ // does, so a report filed without them still says which build and
+ // platform it came from.
+ let version = if version.trim().is_empty() {
+ format!("xerj v{}", env!("CARGO_PKG_VERSION"))
+ } else {
+ version
+ };
+ let os = if os.trim().is_empty() {
+ format!("{} {}", std::env::consts::OS, std::env::consts::ARCH)
+ } else {
+ os
+ };
let indexed = match opt_text(args, "indexed") {
Ok(v) => v,
Err(msg) => return tool_text(msg, true),
@@ -3997,6 +4010,22 @@ mod tests {
assert!(!request.contains(token), "{request}");
assert!(request.contains("\"agent\":\"Test Agent\""), "{request}");
assert!(request.contains("\"notes\":\"full report\""), "{request}");
+ // version and os were omitted: the observable facts are filled in.
+ assert!(
+ request.contains(&format!(
+ "\"version\":\"xerj v{}\"",
+ env!("CARGO_PKG_VERSION")
+ )),
+ "{request}"
+ );
+ assert!(
+ request.contains(&format!(
+ "\"os\":\"{} {}\"",
+ std::env::consts::OS,
+ std::env::consts::ARCH
+ )),
+ "{request}"
+ );
}
/// GitHub first, endpoint second: with no `xerj` (and so no PR path)
diff --git a/landing/docs/agents/schemas/mcp-tools.json b/landing/docs/agents/schemas/mcp-tools.json
index bde894bc5..30fc8e3c8 100644
--- a/landing/docs/agents/schemas/mcp-tools.json
+++ b/landing/docs/agents/schemas/mcp-tools.json
@@ -636,15 +636,15 @@
},
"verdict": {
"type": "string",
- "description": "What worked and what did not. Capped at 80 characters on the wire; put the long text in notes."
+ "description": "What worked and what did not, in one or two sentences (up to 1000 characters). Put the long report in notes."
},
"version": {
"type": "string",
- "description": "xerj version, if known. Optional."
+ "description": "xerj version. Optional: when omitted, this binary's own version is sent."
},
"os": {
"type": "string",
- "description": "OS and architecture. Optional."
+ "description": "OS and architecture. Optional: when omitted, this machine's OS and architecture are sent."
},
"indexed": {
"type": "string",