Skip to content

armgit / xtool

Public Imported from GitHub
0

Cross-platform Xcode replacement. Build and deploy iOS apps with SwiftPM on Linux, Windows, macOS.

Replace `#warning`s with FIXMEs

kabiroberai018212791bf7
diff --git a/Supersign/Sources/Supersign/GrandSlam/Anisette/DeviceInfo+Fetching.swift b/Supersign/Sources/Supersign/GrandSlam/Anisette/DeviceInfo+Fetching.swift
index 8fa44a7..1823ed3 100644
--- a/Supersign/Sources/Supersign/GrandSlam/Anisette/DeviceInfo+Fetching.swift
+++ b/Supersign/Sources/Supersign/GrandSlam/Anisette/DeviceInfo+Fetching.swift
@@ -97,5 +97,5 @@ extension DeviceInfo {
}
#endif
-#warning("Figure out DeviceInfo.current() on Windows/Linux")
+// FIXME: Figure out DeviceInfo.current() on Windows/Linux
// (see above)
diff --git a/Supersign/Sources/Supersign/Model/Entitlements/EntitlementTypes.swift b/Supersign/Sources/Supersign/Model/Entitlements/EntitlementTypes.swift
index 6a11566..180531d 100644
--- a/Supersign/Sources/Supersign/Model/Entitlements/EntitlementTypes.swift
+++ b/Supersign/Sources/Supersign/Model/Entitlements/EntitlementTypes.swift
@@ -66,7 +66,7 @@ public struct KeychainAccessGroupsEntitlement: Entitlement, RawRepresentable {
public struct AppGroupEntitlement: Entitlement, RawRepresentable {
public static let identifier = "com.apple.security.application-groups"
- #warning("Enable app groups on free accounts")
+ // FIXME: Enable app groups on free accounts
// but first we need to fix the bug where it only assigns one
// app group even if the ents say there are multiple
public static let isFree = false
diff --git a/Supersign/Sources/Supersign/Utilities/ProvisioningIdentifiers.swift b/Supersign/Sources/Supersign/Utilities/ProvisioningIdentifiers.swift
index d84dc32..67e8a1e 100644
--- a/Supersign/Sources/Supersign/Utilities/ProvisioningIdentifiers.swift
+++ b/Supersign/Sources/Supersign/Utilities/ProvisioningIdentifiers.swift
@@ -21,8 +21,9 @@ extension ProvisioningIdentifiers {
return identifier.split(separator: ".").dropFirst().joined(separator: ".")
}
- #warning("TODO: Remove context option; that's a temporary measure")
static func identifier(fromSanitized sanitized: String, context: SigningContext? = nil) -> String {
+ // FIXME: Use something better than the team ID to generate the prefix. Maybe a random
+ // UUID works as long as we can remember what the random UUID for each app was.
let uuid = context?.teamID.rawValue ?? String(UUID().uuidString.split(separator: "-")[0])
return "\(Self.idPrefix)\(uuid).\(sanitized)"
}