Skip to content

armgit / xtool

Public Imported from GitHub
0

Cross-platform Xcode replacement. Build and deploy iOS apps with SwiftPM on Linux, Windows, macOS.

More Supersign improvements and bug-fixes

kabiroberai9ab597d08006
diff --git a/Supersign/Installation/AppInstaller.swift b/Supersign/Installation/AppInstaller.swift
index e104798..ac17b93 100644
--- a/Supersign/Installation/AppInstaller.swift
+++ b/Supersign/Installation/AppInstaller.swift
@@ -45,14 +45,11 @@ public class AppInstaller {
value: "Uploading",
comment: ""
)
- case .installing(let details, _):
- return String.localizedStringWithFormat(
- NSLocalizedString(
- "app_installer.stage.installing",
- value: "Installing: %@",
- comment: "The %@ represents the stage reported by Apple (eg. VerifyingApplication)"
- ),
- details
+ case .installing:
+ return NSLocalizedString(
+ "app_installer.stage.installing",
+ value: "Installing",
+ comment: ""
)
}
}
diff --git a/Supersign/Installation/IPAUploader.swift b/Supersign/Installation/IPAUploader.swift
index 04a47ed..6c9f6e8 100644
--- a/Supersign/Installation/IPAUploader.swift
+++ b/Supersign/Installation/IPAUploader.swift
@@ -48,6 +48,7 @@ public class IPAUploader {
buf = srcHandle.readData(ofLength: 1 << 20) // 1 MB
var bufWritten = 0
while bufWritten < buf.count {
+ // not sure if rewriting the same buf is a bug but ideviceinstaller does it this way
let written = try destFile.write(buf)
bufWritten += written
totalWritten += written
diff --git a/Supersign/Signer/Signer.swift b/Supersign/Signer/Signer.swift
index d3b8290..cedcd33 100644
--- a/Supersign/Signer/Signer.swift
+++ b/Supersign/Signer/Signer.swift
@@ -86,6 +86,7 @@ public struct Signer {
progress: @escaping (Double) -> Void,
completion: @escaping (Result<(), Swift.Error>) -> Void
) {
+ status(NSLocalizedString("signer.signing", value: "Signing", comment: ""))
DeveloperServicesProvisioningOperation(context: context, app: app).perform { result in
guard let response = result.get(withErrorHandler: completion) else { return }
self.sign(
diff --git a/Supersign/Utilities/KeyValueStorage.swift b/Supersign/Utilities/KeyValueStorage.swift
index c892c60..4980ffe 100644
--- a/Supersign/Utilities/KeyValueStorage.swift
+++ b/Supersign/Utilities/KeyValueStorage.swift
@@ -46,7 +46,7 @@ extension KeyValueStorage {
#if canImport(Security)
import Security
-public struct KeychainKeyValueStorage: KeyValueStorage {
+public struct KeychainStorage: KeyValueStorage {
public let service: String?
public init(service: String? = nil) {