Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
extensions_ui: Make feature upsell rendering a bit more efficient (#64767)
Finn Evers70e686c2a377
diff --git a/crates/extensions_ui/src/extensions_ui.rs b/crates/extensions_ui/src/extensions_ui.rsindex a251f056824..b5bf231e665 100644--- a/crates/extensions_ui/src/extensions_ui.rs+++ b/crates/extensions_ui/src/extensions_ui.rs@@ -1016,10 +1016,10 @@ impl ExtensionsPage {fn render_feature_upsell_banner(&self,- label: SharedString,- docs_url: SharedString,+ label: &'static str,+ docs_url: &'static str,vim: bool,- cx: &mut Context<Self>,+ cx: &Context<Self>,) -> impl IntoElement {let docs_url_button = Button::new("open_docs", "View Documentation").end_icon(Icon::new(IconName::ArrowUpRight).size(IconSize::Small))@@ -1030,7 +1030,7 @@ impl ExtensionsPage {source = "Feature Upsell",url = docs_url,);- cx.open_url(&docs_url)+ cx.open_url(docs_url)}});@@ -1040,7 +1040,7 @@ impl ExtensionsPage {.child(Banner::new().severity(Severity::Success)- .child(Label::new(label).mt_0p5())+ .child(Label::new(SharedString::new_static(label)).mt_0p5()).map(|this| {if vim {this.action_slot(@@ -1088,125 +1088,117 @@ impl ExtensionsPage {.into_any_element()}- fn render_feature_upsells(&self, cx: &mut Context<Self>) -> impl IntoElement {- let mut container = v_flex();-- for feature in &self.upsells {- let banner = match feature {- Feature::AgentClaude => self.render_feature_upsell_banner(- "Claude Agent support is built-in to Zed!".into(),- "https://zed.dev/docs/ai/external-agents#claude-agent".into(),- false,- cx,- ),- Feature::AgentCodex => self.render_feature_upsell_banner(- "Codex CLI support is built-in to Zed!".into(),- "https://zed.dev/docs/ai/external-agents#codex-cli".into(),- false,- cx,- ),- Feature::AgentGemini => self.render_feature_upsell_banner(- "Gemini CLI support is built-in to Zed!".into(),- "https://zed.dev/docs/ai/external-agents#gemini-cli".into(),- false,- cx,- ),- Feature::ExtensionBasedpyright => self.render_feature_upsell_banner(- "Basedpyright (Python language server) support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/python#basedpyright".into(),- false,- cx,- ),- Feature::ExtensionRuff => self.render_feature_upsell_banner(- "Ruff (linter for Python) support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/python#code-formatting--linting".into(),- false,- cx,- ),- Feature::ExtensionTailwind => self.render_feature_upsell_banner(- "Tailwind CSS support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/tailwindcss".into(),- false,- cx,- ),- Feature::ExtensionTy => self.render_feature_upsell_banner(- "Ty (Python language server) support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/python".into(),- false,- cx,- ),- Feature::Git => self.render_feature_upsell_banner(- "Zed comes with basic Git support—more features are coming in the future."- .into(),- "https://zed.dev/docs/git".into(),- false,- cx,- ),- Feature::LanguageBash => self.render_feature_upsell_banner(- "Shell support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/bash".into(),- false,- cx,- ),- Feature::LanguageC => self.render_feature_upsell_banner(- "C support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/c".into(),- false,- cx,- ),- Feature::LanguageCpp => self.render_feature_upsell_banner(- "C++ support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/cpp".into(),- false,- cx,- ),- Feature::LanguageGo => self.render_feature_upsell_banner(- "Go support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/go".into(),- false,- cx,- ),- Feature::LanguagePython => self.render_feature_upsell_banner(- "Python support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/python".into(),- false,- cx,- ),- Feature::LanguageReact => self.render_feature_upsell_banner(- "React support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/typescript".into(),- false,- cx,- ),- Feature::LanguageRust => self.render_feature_upsell_banner(- "Rust support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/rust".into(),- false,- cx,- ),- Feature::LanguageTypescript => self.render_feature_upsell_banner(- "Typescript support is built-in to Zed!".into(),- "https://zed.dev/docs/languages/typescript".into(),- false,- cx,- ),- Feature::OpenIn => self.render_feature_upsell_banner(- "Zed supports linking to a source line on GitHub and others.".into(),- "https://zed.dev/docs/git#git-integrations".into(),- false,- cx,- ),- Feature::Vim => self.render_feature_upsell_banner(- "Vim support is built-in to Zed!".into(),- "https://zed.dev/docs/vim".into(),- true,- cx,- ),- };- container = container.child(banner);- }-- container+ fn render_feature_upsells(&self, cx: &Context<Self>) -> impl IntoElement {+ v_flex().children(self.upsells.iter().map(|feature| match feature {+ Feature::AgentClaude => self.render_feature_upsell_banner(+ "Claude Agent support is built-in to Zed!",+ "https://zed.dev/docs/ai/external-agents#claude-agent",+ false,+ cx,+ ),+ Feature::AgentCodex => self.render_feature_upsell_banner(+ "Codex CLI support is built-in to Zed!",+ "https://zed.dev/docs/ai/external-agents#codex-cli",+ false,+ cx,+ ),+ Feature::AgentGemini => self.render_feature_upsell_banner(+ "Gemini CLI support is built-in to Zed!",+ "https://zed.dev/docs/ai/external-agents#gemini-cli",+ false,+ cx,+ ),+ Feature::ExtensionBasedpyright => self.render_feature_upsell_banner(+ "Basedpyright (Python language server) support is built-in to Zed!",+ "https://zed.dev/docs/languages/python#basedpyright",+ false,+ cx,+ ),+ Feature::ExtensionRuff => self.render_feature_upsell_banner(+ "Ruff (linter for Python) support is built-in to Zed!",+ "https://zed.dev/docs/languages/python#code-formatting--linting",+ false,+ cx,+ ),+ Feature::ExtensionTailwind => self.render_feature_upsell_banner(+ "Tailwind CSS support is built-in to Zed!",+ "https://zed.dev/docs/languages/tailwindcss",+ false,+ cx,+ ),+ Feature::ExtensionTy => self.render_feature_upsell_banner(+ "Ty (Python language server) support is built-in to Zed!",+ "https://zed.dev/docs/languages/python",+ false,+ cx,+ ),+ Feature::Git => self.render_feature_upsell_banner(+ "Zed comes with basic Git support—more features are coming in the future.",+ "https://zed.dev/docs/git",+ false,+ cx,+ ),+ Feature::LanguageBash => self.render_feature_upsell_banner(+ "Shell support is built-in to Zed!",+ "https://zed.dev/docs/languages/bash",+ false,+ cx,+ ),+ Feature::LanguageC => self.render_feature_upsell_banner(+ "C support is built-in to Zed!",+ "https://zed.dev/docs/languages/c",+ false,+ cx,+ ),+ Feature::LanguageCpp => self.render_feature_upsell_banner(+ "C++ support is built-in to Zed!",+ "https://zed.dev/docs/languages/cpp",+ false,+ cx,+ ),+ Feature::LanguageGo => self.render_feature_upsell_banner(+ "Go support is built-in to Zed!",+ "https://zed.dev/docs/languages/go",+ false,+ cx,+ ),+ Feature::LanguagePython => self.render_feature_upsell_banner(+ "Python support is built-in to Zed!",+ "https://zed.dev/docs/languages/python",+ false,+ cx,+ ),+ Feature::LanguageReact => self.render_feature_upsell_banner(+ "React support is built-in to Zed!",+ "https://zed.dev/docs/languages/typescript",+ false,+ cx,+ ),+ Feature::LanguageRust => self.render_feature_upsell_banner(+ "Rust support is built-in to Zed!",+ "https://zed.dev/docs/languages/rust",+ false,+ cx,+ ),+ Feature::LanguageTypescript => self.render_feature_upsell_banner(+ "Typescript support is built-in to Zed!",+ "https://zed.dev/docs/languages/typescript",+ false,+ cx,+ ),+ Feature::OpenIn => self.render_feature_upsell_banner(+ "Zed supports linking to a source line on GitHub and others.",+ "https://zed.dev/docs/git#git-integrations",+ false,+ cx,+ ),+ Feature::Vim => self.render_feature_upsell_banner(+ "Vim support is built-in to Zed!",+ "https://zed.dev/docs/vim",+ true,+ cx,+ ),+ }))}}