Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
GitHub board automation: remove redundant event handling (#56429)
Lenaa3781513ba89
diff --git a/.github/workflows/community_pr_board.yml b/.github/workflows/community_pr_board.ymlindex ac848a5835e..03bb9381739 100644--- a/.github/workflows/community_pr_board.yml+++ b/.github/workflows/community_pr_board.yml@@ -2,8 +2,10 @@## When an area/platform label is added to a community PR (not staff, not bot),# the PR is added to the project board with a Track field set to the matching-# review area group. Status transitions are driven by assignment, review,-# re-request, and comment events.+# review area group. Status transitions for assignment, re-request, and+# comment events are handled here. Review-based status changes (approved →+# "In Progress (us)", changes requested → "In Progress (author)") are handled+# by built-in board automations.## See script/community-pr-track-mapping.json for the label→track mapping.@@ -12,8 +14,6 @@ name: Community PR Boardon:pull_request_target:types: [labeled, unlabeled, assigned, review_requested]- pull_request_review:- types: [submitted]issue_comment:types: [created]workflow_dispatch:@@ -36,7 +36,9 @@ jobs:github.repository == 'zed-industries/zed' &&(github.event_name != 'issue_comment' ||(github.event.issue.pull_request &&- github.event.comment.user.login == github.event.issue.user.login))+ github.event.comment.user.login == github.event.issue.user.login)) &&+ !contains(toJSON(github.event.pull_request.labels.*.name), 'staff') &&+ !contains(toJSON(github.event.pull_request.labels.*.name), 'bot')runs-on: namespace-profile-2x4-ubuntu-2404timeout-minutes: 5diff --git a/script/github-community-pr-board.py b/script/github-community-pr-board.pyindex 447396c00bb..cd79149db0a 100644--- a/script/github-community-pr-board.py+++ b/script/github-community-pr-board.py@@ -15,11 +15,12 @@ Reads the event payload dispatched by the GitHub Actions workflow and:- On `issue_comment.created`: if the commenter is the PR author andcurrent Status is "In Progress (author)", flips it to"In Progress (us)" — the author is likely signaling they're done.-- On `pull_request_review.submitted`: if the reviewer is a team member,- sets Status to "In Progress (author)" (for COMMENT / REQUEST_CHANGES)- or "In Progress (us)" (for APPROVE — reviewer still needs to merge).- On `workflow_dispatch`: re-resolves Track for a manually specified PR.+Review-based status changes (approved → "In Progress (us)", changes+requested → "In Progress (author)") are handled by built-in board+automations, not this script.+Requires:requests (pip install requests)@@ -48,7 +49,9 @@ SKIP_LABELS = {"staff", "bot"}STATUS_IN_PROGRESS_US = "In Progress (us)"-STATUS_IN_PROGRESS_AUTHOR = "In Progress (author)"+STATUS_IN_PROGRESS_AUTHOR = (+ "In Progress (author)" # set by built-in board automation, read by this script+)MAPPING_PATH = Path(__file__).parent / "community-pr-track-mapping.json"@@ -115,35 +118,6 @@ def return_to_reviewer(pr, project_number, reason):print(f"Current status is '{current_status}', not flipping ({reason})")-def set_status_after_review(pr, review, project_number):- """On review submitted: set project Status based on review outcome."""- reviewer = review.get("user", {}).get("login", "unknown")- if not github_is_staff_member(reviewer):- print(f"Reviewer '{reviewer}' is not a staff member, skipping")- return- if reviewer == pr.get("user", {}).get("login"):- print(f"Reviewer {reviewer} is the PR author, skipping")- return-- project = github_fetch_project(project_number)- item_id = github_find_project_item(project["id"], pr["node_id"])- if not item_id:- print(f"PR #{pr['number']} not on board, skipping review status update")- return-- review_state = review.get("state", "")- # to not lose the PRs that we approved but forgot to merge- if review_state == "approved":- new_status = STATUS_IN_PROGRESS_US- else:- new_status = STATUS_IN_PROGRESS_AUTHOR-- print(- f"Team review by {reviewer} ({review_state}), setting status to '{new_status}'"- )- github_set_project_field(project, item_id, "Status", new_status)--def load_mapping(path=MAPPING_PATH):"""Load the Track-to-labels mapping from the JSON file."""with open(path) as f:@@ -431,9 +405,6 @@ if __name__ == "__main__":if event_name in ("pull_request", "pull_request_target"):pr = event["pull_request"]action = event["action"]- elif event_name == "pull_request_review":- pr = event["pull_request"]- action = "review_submitted"elif event_name == "issue_comment":issue = event["issue"]if "pull_request" not in issue:@@ -475,7 +446,5 @@ if __name__ == "__main__":return_to_reviewer(pr, project_number, "Author re-requested review")elif action == "author_commented":return_to_reviewer(pr, project_number, "Author commented on PR")- elif action == "review_submitted":- set_status_after_review(pr, event["review"], project_number)else:print(f"Ignoring action: {action}")