Skip to content

armgit / zed

Public Imported from GitHub
0

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

markdown_preview: Make markdown preview clone and splittable (#65136)

Young Seo Kimb92c02953890
diff --git a/crates/markdown_preview/src/markdown_preview_view.rs b/crates/markdown_preview/src/markdown_preview_view.rs
index 20064c0783f..81cb5cde8d4 100644
--- a/crates/markdown_preview/src/markdown_preview_view.rs
+++ b/crates/markdown_preview/src/markdown_preview_view.rs
@@ -1792,6 +1792,39 @@ impl Item for MarkdownPreviewView {
) -> Option<Box<dyn SearchableItemHandle>> {
Some(Box::new(handle.clone()))
}
+
+ fn can_split(&self) -> bool {
+ true
+ }
+
+ fn clone_on_split(
+ &self,
+ _workspace_id: Option<WorkspaceId>,
+ window: &mut Window,
+ cx: &mut Context<Self>,
+ ) -> Task<Option<Entity<Self>>>
+ where
+ Self: Sized,
+ {
+ let Some(active_editor) = self.active_editor.as_ref() else {
+ return Task::ready(None);
+ };
+
+ let Some(project) = active_editor.editor.read(cx).project() else {
+ return Task::ready(None);
+ };
+
+ let language_registry = project.read(cx).languages().clone();
+
+ Task::ready(Some(MarkdownPreviewView::new(
+ MarkdownPreviewMode::Default,
+ active_editor.editor.clone(),
+ self.workspace.clone(),
+ language_registry,
+ window,
+ cx,
+ )))
+ }
}
impl Render for MarkdownPreviewView {
@@ -3295,6 +3328,39 @@ mod tests {
});
}
+ #[gpui::test]
+ async fn splitting_preview_clones_into_new_pane(cx: &mut TestAppContext) {
+ let (multi_workspace, _) = open_markdown_file(cx, "note.md", "# Note\n\nBody text\n").await;
+ let _preview = open_preview_for_active_editor(cx, &multi_workspace);
+ cx.run_until_parked();
+
+ let new_pane = multi_workspace
+ .update(cx, |multi_workspace, window, cx| {
+ let workspace = multi_workspace.workspace().clone();
+ workspace.update(cx, |workspace, cx| {
+ workspace.split_and_clone(
+ workspace.active_pane().clone(),
+ workspace::SplitDirection::Right,
+ window,
+ cx,
+ )
+ })
+ })
+ .unwrap()
+ .await
+ .unwrap();
+ cx.run_until_parked();
+
+ new_pane.read_with(cx, |pane, _| {
+ assert!(
+ pane.active_item()
+ .and_then(|item| item.downcast::<MarkdownPreviewView>())
+ .is_some(),
+ "splitting a preview should clone it into a new pane"
+ );
+ });
+ }
+
#[gpui::test]
async fn close_and_return_to_editor_closes_preview_and_focuses_source_editor(
cx: &mut TestAppContext,