Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
gpui: Composite translucent layers with source-over alpha (#65571)
Hieu Lee18de65b7590
diff --git a/crates/gpui_apple/src/metal_renderer.rs b/crates/gpui_apple/src/metal_renderer.rsindex e46620587fd..e29d61c537b 100644--- a/crates/gpui_apple/src/metal_renderer.rs+++ b/crates/gpui_apple/src/metal_renderer.rs@@ -1365,7 +1365,7 @@ fn build_pipeline_state(color_attachment.set_source_rgb_blend_factor(metal::MTLBlendFactor::SourceAlpha);color_attachment.set_source_alpha_blend_factor(metal::MTLBlendFactor::One);color_attachment.set_destination_rgb_blend_factor(metal::MTLBlendFactor::OneMinusSourceAlpha);- color_attachment.set_destination_alpha_blend_factor(metal::MTLBlendFactor::One);+ color_attachment.set_destination_alpha_blend_factor(metal::MTLBlendFactor::OneMinusSourceAlpha);device.new_render_pipeline_state(&descriptor)@@ -1399,7 +1399,7 @@ fn build_path_sprite_pipeline_state(color_attachment.set_source_rgb_blend_factor(metal::MTLBlendFactor::One);color_attachment.set_source_alpha_blend_factor(metal::MTLBlendFactor::One);color_attachment.set_destination_rgb_blend_factor(metal::MTLBlendFactor::OneMinusSourceAlpha);- color_attachment.set_destination_alpha_blend_factor(metal::MTLBlendFactor::One);+ color_attachment.set_destination_alpha_blend_factor(metal::MTLBlendFactor::OneMinusSourceAlpha);device.new_render_pipeline_state(&descriptor)diff --git a/crates/gpui_wgpu/src/wgpu_renderer.rs b/crates/gpui_wgpu/src/wgpu_renderer.rsindex 8387528acbe..ff4af7d26e1 100644--- a/crates/gpui_wgpu/src/wgpu_renderer.rs+++ b/crates/gpui_wgpu/src/wgpu_renderer.rs@@ -814,19 +814,6 @@ impl WgpuRendererCore {&shader_module,);- let paths_blend = wgpu::BlendState {- color: wgpu::BlendComponent {- src_factor: wgpu::BlendFactor::One,- dst_factor: wgpu::BlendFactor::OneMinusSrcAlpha,- operation: wgpu::BlendOperation::Add,- },- alpha: wgpu::BlendComponent {- src_factor: wgpu::BlendFactor::One,- dst_factor: wgpu::BlendFactor::One,- operation: wgpu::BlendOperation::Add,- },- };-let paths = create_pipeline("paths","vs_path",@@ -837,7 +824,7 @@ impl WgpuRendererCore {wgpu::PrimitiveTopology::TriangleStrip,&[Some(wgpu::ColorTargetState {format: surface_format,- blend: Some(paths_blend),+ blend: Some(wgpu::BlendState::PREMULTIPLIED_ALPHA_BLENDING),write_mask: wgpu::ColorWrites::ALL,})],1,diff --git a/crates/gpui_windows/src/directx_renderer.rs b/crates/gpui_windows/src/directx_renderer.rsindex f8b86bc25bd..98a13f304c8 100644--- a/crates/gpui_windows/src/directx_renderer.rs+++ b/crates/gpui_windows/src/directx_renderer.rs@@ -1500,7 +1500,7 @@ fn create_blend_state(device: &ID3D11Device) -> Result<ID3D11BlendState> {desc.RenderTarget[0].SrcBlend = D3D11_BLEND_SRC_ALPHA;desc.RenderTarget[0].SrcBlendAlpha = D3D11_BLEND_ONE;desc.RenderTarget[0].DestBlend = D3D11_BLEND_INV_SRC_ALPHA;- desc.RenderTarget[0].DestBlendAlpha = D3D11_BLEND_ONE;+ desc.RenderTarget[0].DestBlendAlpha = D3D11_BLEND_INV_SRC_ALPHA;desc.RenderTarget[0].RenderTargetWriteMask = D3D11_COLOR_WRITE_ENABLE_ALL.0 as u8;unsafe {let mut state = None;@@ -1561,7 +1561,7 @@ fn create_blend_state_for_path_sprite(device: &ID3D11Device) -> Result<ID3D11Bledesc.RenderTarget[0].SrcBlend = D3D11_BLEND_ONE;desc.RenderTarget[0].SrcBlendAlpha = D3D11_BLEND_ONE;desc.RenderTarget[0].DestBlend = D3D11_BLEND_INV_SRC_ALPHA;- desc.RenderTarget[0].DestBlendAlpha = D3D11_BLEND_ONE;+ desc.RenderTarget[0].DestBlendAlpha = D3D11_BLEND_INV_SRC_ALPHA;desc.RenderTarget[0].RenderTargetWriteMask = D3D11_COLOR_WRITE_ENABLE_ALL.0 as u8;unsafe {let mut state = None;