Skip to content

armgit / zed

Public Imported from GitHub
0

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

Add reasoning effort support for Mistral models (#61393)

ummon-vf8d25456c21c
diff --git a/crates/language_models/src/provider/mistral.rs b/crates/language_models/src/provider/mistral.rs
index a45564b191b..c3fe10aeb49 100644
--- a/crates/language_models/src/provider/mistral.rs
+++ b/crates/language_models/src/provider/mistral.rs
@@ -578,6 +578,11 @@ pub fn into_mistral(
})
})
.collect::<Result<_>>()?,
+ reasoning_effort: if model.supports_thinking() && request.thinking_allowed {
+ Some(mistral::ReasoningEffort::High)
+ } else {
+ None
+ },
},
request.thread_id,
))
@@ -886,6 +891,44 @@ mod tests {
assert_eq!(affinity, Some("abcdef".into()));
}
+ #[test]
+ fn test_into_mistral_reasoning_effort() {
+ let request = |thinking_allowed| LanguageModelRequest {
+ messages: vec![LanguageModelRequestMessage {
+ role: Role::User,
+ content: vec![MessageContent::Text("Hello".into())],
+ cache: false,
+ reasoning_details: None,
+ }],
+ temperature: None,
+ tools: vec![],
+ tool_choice: None,
+ thread_id: None,
+ prompt_id: None,
+ intent: None,
+ stop: vec![],
+ thinking_allowed,
+ thinking_effort: None,
+ speed: Default::default(),
+ compact_at_tokens: None,
+ };
+
+ let (mistral_request, _) =
+ into_mistral(request(true), mistral::Model::MistralMediumLatest, None).unwrap();
+ assert_eq!(
+ mistral_request.reasoning_effort,
+ Some(mistral::ReasoningEffort::High)
+ );
+
+ let (mistral_request, _) =
+ into_mistral(request(false), mistral::Model::MistralMediumLatest, None).unwrap();
+ assert_eq!(mistral_request.reasoning_effort, None);
+
+ let (mistral_request, _) =
+ into_mistral(request(true), mistral::Model::CodestralLatest, None).unwrap();
+ assert_eq!(mistral_request.reasoning_effort, None);
+ }
+
#[test]
fn test_into_mistral_with_image() {
let request = LanguageModelRequest {
diff --git a/crates/mistral/src/mistral.rs b/crates/mistral/src/mistral.rs
index c6e6007186a..0b76b1d665f 100644
--- a/crates/mistral/src/mistral.rs
+++ b/crates/mistral/src/mistral.rs
@@ -91,6 +91,9 @@ impl Model {
"mistral-large-latest" => Ok(Self::MistralLargeLatest),
"mistral-medium-latest" => Ok(Self::MistralMediumLatest),
"mistral-small-latest" => Ok(Self::MistralSmallLatest),
+ "ministral-3b-latest" => Ok(Self::Ministral3bLatest),
+ "ministral-8b-latest" => Ok(Self::Ministral8bLatest),
+ "ministral-14b-latest" => Ok(Self::Ministral14bLatest),
invalid_id => anyhow::bail!("invalid model id '{invalid_id}'"),
}
}
@@ -175,7 +178,7 @@ impl Model {
pub fn supports_thinking(&self) -> bool {
match self {
- Self::MistralMediumLatest => true,
+ Self::MistralMediumLatest | Self::MistralSmallLatest => true,
Self::Custom {
supports_thinking, ..
} => supports_thinking.unwrap_or(false),
@@ -203,6 +206,15 @@ pub struct Request {
pub parallel_tool_calls: Option<bool>,
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub tools: Vec<ToolDefinition>,
+ #[serde(default, skip_serializing_if = "Option::is_none")]
+ pub reasoning_effort: Option<ReasoningEffort>,
+}
+
+#[derive(Clone, Copy, Debug, Serialize, Deserialize, Eq, PartialEq)]
+#[serde(rename_all = "lowercase")]
+pub enum ReasoningEffort {
+ None,
+ High,
}
#[derive(Debug, Serialize, Deserialize)]