Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

22.3 KB
Raw Blame
"use strict";

const assert = require("node:assert/strict");

const {make_user_group} = require("./lib/example_group.cjs");
const {make_realm} = require("./lib/example_realm.cjs");
const {make_stream} = require("./lib/example_stream.cjs");
const {make_user} = require("./lib/example_user.cjs");
const {mock_esm, set_global, zrequire} = require("./lib/namespace.cjs");
const {run_test, noop} = require("./lib/test.cjs");
const {$} = require("./lib/zjquery.cjs");
const {page_params} = require("./lib/zpage_params.cjs");

const people = zrequire("people");
const {set_current_user, set_realm} = zrequire("state_data");

set_global("document", "document-stub");

page_params.realm_users = [];
const current_user = {};
set_current_user(current_user);

// We use this with override.
let unread_unmuted_count;
let stream_has_any_unread_mentions;

const topic_list = mock_esm("../src/topic_list");
mock_esm("../src/unread", {
    unread_count_info_for_stream: () => ({
        unmuted_count: unread_unmuted_count,
        stream_is_muted: false,
        muted_count: 0,
    }),
    get_counts: () => ({
        mentioned_message_count: 222,
        home_unread_messages: 333,
        stream_unread_messages: 666,
    }),
    stream_has_any_unread_mentions: () => stream_has_any_unread_mentions,
    stream_has_any_unmuted_mentions: () => noop,
});

const {Filter} = zrequire("../src/filter");
const left_sidebar_navigation_area = zrequire("left_sidebar_navigation_area");
const stream_data = zrequire("stream_data");
const stream_list = zrequire("stream_list");
stream_list.set_update_inbox_channel_view_callback(noop);
const stream_list_sort = zrequire("stream_list_sort");
const user_groups = zrequire("user_groups");
const {initialize_user_settings} = zrequire("user_settings");
const settings_config = zrequire("settings_config");
mock_esm("../src/settings_data", {
    user_can_create_private_streams: () => true,
    user_has_permission_for_group_setting: () => true,
    should_mask_unread_count: () => false,
});

// Start with always filtering out inactive streams.
const user_settings = {
    demote_inactive_streams: settings_config.demote_inactive_streams_values.always.code,
    web_channel_default_view: settings_config.web_channel_default_view_values.channel_feed.code,
};
initialize_user_settings({user_settings});
stream_list_sort.set_filter_out_inactives();

const realm = make_realm({
    realm_topics_policy: "allow_empty_topic",
});
set_realm(realm);

const me = make_user({
    email: "[email protected]",
    user_id: 30,
    full_name: "Me Myself",
});

people.add_active_user(me);
people.initialize_current_user(me.user_id);

const everyone_group = make_user_group({
    name: "Everyone",
    id: 1,
    members: new Set([30]),
    direct_subgroup_ids: new Set(),
});

user_groups.initialize({realm_user_groups: [everyone_group]});

const devel = make_stream({
    name: "devel",
    stream_id: 100,
    color: "blue",
    subscribed: true,
    pin_to_top: true,
    is_recently_active: false,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

const social = make_stream({
    name: "social",
    stream_id: 200,
    color: "green",
    subscribed: true,
    is_recently_active: true,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

function create_devel_sidebar_row({mock_template}) {
    const $devel_count = $.create("devel-count");
    const $subscription_block = $.create("devel-block");
    const $devel_unread_mention_info = $.create("devel-unread-mention-info");

    const $sidebar_row = $("<devel-sidebar-row-stub>");

    $sidebar_row.set_find_results(".subscription_block", $subscription_block);
    $subscription_block.set_find_results(".unread_count", $devel_count);
    $subscription_block.set_find_results(".unread_mention_info", $devel_unread_mention_info);

    mock_template("stream_sidebar_row.hbs", false, (data) => {
        assert.equal(data.url, "#narrow/channel/100-devel");
        return "<devel-sidebar-row-stub>";
    });

    unread_unmuted_count = 42;
    stream_has_any_unread_mentions = false;
    stream_list.create_sidebar_row(devel);
    assert.equal($devel_count.text(), "42");
    assert.equal($devel_unread_mention_info.text(), "");
}

function create_social_sidebar_row({mock_template}) {
    const $social_count = $.create("social-count");
    const $subscription_block = $.create("social-block");
    const $social_unread_mention_info = $.create("social-unread-mention-info");

    const $sidebar_row = $("<social-sidebar-row-stub>");

    $sidebar_row.set_find_results(".subscription_block", $subscription_block);
    $subscription_block.set_find_results(".unread_count", $social_count);
    $subscription_block.set_find_results(".unread_mention_info", $social_unread_mention_info);

    mock_template("stream_sidebar_row.hbs", false, (data) => {
        assert.equal(data.url, "#narrow/channel/200-social");
        return "<social-sidebar-row-stub>";
    });

    unread_unmuted_count = 99;
    stream_has_any_unread_mentions = true;
    stream_list.create_sidebar_row(social);
    assert.equal($social_count.text(), "99");
    assert.equal($social_unread_mention_info.text(), "@");
}

function test_ui(label, f) {
    run_test(label, (helpers) => {
        stream_data.clear_subscriptions();
        stream_list.stream_sidebar.rows.clear();
        f(helpers);
    });
}

test_ui("create_sidebar_row", ({override, override_rewire, mock_template}) => {
    // Make a couple calls to create_sidebar_row() and make sure they
    // generate the right markup as well as play nice with get_stream_li().
    override(user_settings, "demote_inactive_streams", 1);
    const appended_sections = [];
    override_rewire(stream_list, "stream_list_section_container_html", (section) => {
        appended_sections.push(section.id);
        return `<stub-section-${section.id}>`;
    });
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);

    const pinned_streams = [];
    $("#stream-list-pinned-streams")[0].append = (...streams) => {
        pinned_streams.push(...streams);
    };
    const normal_streams = [];
    $("#stream-list-normal-streams")[0].append = (...streams) => {
        normal_streams.push(...streams);
    };

    stream_data.add_sub_for_tests(devel);
    stream_data.add_sub_for_tests(social);

    create_devel_sidebar_row({mock_template});
    create_social_sidebar_row({mock_template});
    topic_list.get_stream_li = noop;

    const $devel_sidebar = $("<devel-sidebar-row-stub>");
    const $social_sidebar = $("<social-sidebar-row-stub>");

    let topics_closed;
    topic_list.close = () => {
        topics_closed = true;
    };

    stream_list.build_stream_list();
    assert.ok(topics_closed);
    assert.deepEqual(appended_sections, ["pinned-streams", "normal-streams"]);

    assert.deepEqual(pinned_streams, [$devel_sidebar[0]]);
    assert.deepEqual(normal_streams, [$social_sidebar[0]]);

    const $social_li = $("<social-sidebar-row-stub>");
    const stream_id = social.stream_id;

    const $privacy_elem = $.create("privacy-stub");
    $social_li.set_find_results(".stream-privacy", $privacy_elem);

    social.invite_only = true;
    social.color = "#222222";

    mock_template("stream_privacy.hbs", false, (data) => {
        assert.equal(data.invite_only, true);
        return "<div>privacy-html";
    });
    stream_list.redraw_stream_privacy(social);
    assert.equal($privacy_elem.html(), "<div>privacy-html");

    stream_list.set_in_home_view(stream_id, false);
    assert.ok($social_li.hasClass("out_of_home_view"));

    stream_list.set_in_home_view(stream_id, true);
    assert.ok(!$social_li.hasClass("out_of_home_view"));

    const row = stream_list.stream_sidebar.get_row(stream_id);
    social.is_recently_active = true;
    row.update_whether_active();
    assert.ok(!$social_li.hasClass("inactive_stream"));

    social.is_recently_active = false;
    row.update_whether_active();
    assert.ok($social_li.hasClass("inactive_stream"));

    let removed;
    $social_li[0].remove = () => {
        removed = true;
    };

    row.remove();
    assert.ok(removed);
});

test_ui("pinned_streams_never_inactive", ({mock_template, override_rewire}) => {
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);

    stream_data.add_sub_for_tests(devel);
    stream_data.add_sub_for_tests(social);

    create_devel_sidebar_row({mock_template});
    create_social_sidebar_row({mock_template});
    // non-pinned streams can be made inactive
    const $social_sidebar = $("<social-sidebar-row-stub>");
    let stream_id = social.stream_id;
    let row = stream_list.stream_sidebar.get_row(stream_id);
    social.is_recently_active = false;

    stream_list.build_stream_list();
    assert.ok($social_sidebar.hasClass("inactive_stream"));

    social.is_recently_active = true;
    row.update_whether_active();
    assert.ok(!$social_sidebar.hasClass("inactive_stream"));

    social.is_recently_active = false;
    row.update_whether_active();
    assert.ok($social_sidebar.hasClass("inactive_stream"));

    // pinned streams can never be made inactive
    const $devel_sidebar = $("<devel-sidebar-row-stub>");
    stream_id = devel.stream_id;
    row = stream_list.stream_sidebar.get_row(stream_id);
    social.is_recently_active = false;

    stream_list.build_stream_list();
    assert.ok(!$devel_sidebar.hasClass("inactive_stream"));

    row.update_whether_active();
    assert.ok(!$devel_sidebar.hasClass("inactive_stream"));
});

function add_row(sub) {
    stream_data.add_sub_for_tests(sub);
    const row = {
        update_whether_active() {},
        get_li() {
            const html = "<" + sub.name + "-sidebar-row-stub>";
            return $(html);
        },
    };
    stream_list.stream_sidebar.set_row(sub.stream_id, row);
}

const develSub = make_stream({
    name: "devel",
    stream_id: 1000,
    color: "blue",
    pin_to_top: true,
    subscribed: true,
    is_recently_active: true,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

const RomeSub = make_stream({
    name: "Rome",
    stream_id: 2000,
    color: "blue",
    pin_to_top: true,
    subscribed: true,
    is_recently_active: true,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

const testSub = make_stream({
    name: "test",
    stream_id: 3000,
    color: "blue",
    pin_to_top: true,
    subscribed: true,
    is_recently_active: true,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
    is_muted: true,
});

const announceSub = make_stream({
    name: "announce",
    stream_id: 4000,
    color: "green",
    pin_to_top: false,
    subscribed: true,
    is_recently_active: true,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

const DenmarkSub = make_stream({
    name: "Denmark",
    stream_id: 5000,
    color: "green",
    pin_to_top: false,
    subscribed: true,
    is_recently_active: true,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

const carSub = make_stream({
    name: "cars",
    stream_id: 6000,
    color: "green",
    pin_to_top: false,
    subscribed: true,
    is_recently_active: false,
    can_create_topic_group: everyone_group.id,
    can_send_message_group: everyone_group.id,
});

function initialize_stream_data() {
    // pinned streams
    add_row(develSub);
    add_row(RomeSub);
    add_row(testSub);

    // unpinned streams
    add_row(announceSub);
    add_row(DenmarkSub);
    add_row(carSub);

    stream_list.build_stream_list();
}

test_ui("narrowing", ({override_rewire}) => {
    topic_list.close = noop;
    topic_list.rebuild_left_sidebar = noop;
    topic_list.active_stream_id = noop;
    topic_list.get_stream_li = noop;
    override_rewire(stream_list, "scroll_stream_into_view", noop);
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "get_section_id_for_stream_li", () => "normal");
    override_rewire(stream_list, "maybe_hide_topic_bracket", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);

    initialize_stream_data();
    assert.ok(!$("<devel-sidebar-row-stub>").hasClass("active-filter"));

    let filter = new Filter([{operator: "stream", operand: develSub.stream_id.toString()}]);
    stream_list.handle_narrow_activated(filter);
    assert.ok($("<devel-sidebar-row-stub>").hasClass("active-filter"));

    filter = new Filter([
        {operator: "stream", operand: carSub.stream_id.toString()},
        {operator: "topic", operand: "sedans"},
    ]);
    stream_list.handle_narrow_activated(filter);
    assert.ok(!$("ul.filters li").hasClass("active-filter"));
    assert.ok(!$("<cars-sidebar-row-stub>").hasClass("active-filter")); // false because of topic

    filter = new Filter([{operator: "stream", operand: carSub.stream_id.toString()}]);
    stream_list.handle_narrow_activated(filter);
    assert.ok(!$("ul.filters li").hasClass("active-filter"));
    assert.ok($("<cars-sidebar-row-stub>").hasClass("active-filter"));

    $("ul#stream_filters li").addClass("active-filter");
    $("ul#stream_filters li").addClass("stream-expanded");

    let topics_closed;
    topic_list.close = () => {
        topics_closed = true;
    };

    stream_list.handle_message_view_deactivated();
    assert.ok(!$("ul#stream_filters li").hasClass("active-filter"));
    assert.ok(!$("ul#stream_filters li").hasClass("stream-expanded"));
    assert.ok(topics_closed);
});

test_ui("sort_streams", ({override_rewire, mock_template}) => {
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);

    // Get coverage on early-exit.
    stream_list.build_stream_list();

    initialize_stream_data();

    const appended_sections = [];
    override_rewire(stream_list, "stream_list_section_container_html", (section) => {
        appended_sections.push(section.id);
        return `<stub-section-${section.id}>`;
    });

    mock_template("show_inactive_or_muted_channels.hbs", false, () => "<inactive-toggle>");

    const pinned_streams = [];
    $("#stream-list-pinned-streams")[0].append = (...streams) => {
        pinned_streams.push(...streams);
    };
    const normal_streams = [];
    $("#stream-list-normal-streams")[0].append = (...streams) => {
        normal_streams.push(...streams);
    };

    stream_list.build_stream_list(true);

    assert.deepEqual(appended_sections, ["pinned-streams", "normal-streams"]);

    assert.deepEqual(pinned_streams, [
        $("<devel-sidebar-row-stub>")[0],
        $("<Rome-sidebar-row-stub>")[0],
        $("<test-sidebar-row-stub>")[0],
    ]);
    assert.deepEqual(normal_streams, [
        $("<announce-sidebar-row-stub>")[0],
        $("<Denmark-sidebar-row-stub>")[0],
        $("<inactive-toggle>")[0],
        $("<cars-sidebar-row-stub>")[0],
    ]);

    const streams = stream_list_sort.get_stream_ids();

    assert.deepEqual(streams, [
        // two groups: pinned and normal (with dormant at the bottom of the list)
        // pinned
        develSub.stream_id,
        RomeSub.stream_id,
        testSub.stream_id,
        // normal
        announceSub.stream_id,
        DenmarkSub.stream_id,
        // dormant in normal list
        carSub.stream_id,
    ]);

    const denmark_sub = stream_data.get_sub("Denmark");
    const stream_id = denmark_sub.stream_id;
    assert.ok(stream_list.stream_sidebar.has_row_for(stream_id));
    stream_list.remove_sidebar_row(stream_id);
    assert.ok(!stream_list.stream_sidebar.has_row_for(stream_id));
});

test_ui("separators_only_pinned_and_dormant", ({override_rewire}) => {
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);

    // Get coverage on early-exit.
    stream_list.build_stream_list();

    // pinned streams
    const develSub = make_stream({
        name: "devel",
        stream_id: 1000,
        color: "blue",
        pin_to_top: true,
        subscribed: true,
        is_recently_active: true,
    });
    add_row(develSub);

    const RomeSub = make_stream({
        name: "Rome",
        stream_id: 2000,
        color: "blue",
        pin_to_top: true,
        subscribed: true,
        is_recently_active: true,
    });
    add_row(RomeSub);
    // dormant stream
    const DenmarkSub = make_stream({
        name: "Denmark",
        stream_id: 3000,
        color: "blue",
        pin_to_top: false,
        subscribed: true,
        is_recently_active: false,
    });
    add_row(DenmarkSub);

    const appended_sections = [];
    override_rewire(stream_list, "stream_list_section_container_html", (section) => {
        appended_sections.push(section.id);
        return `<stub-section-${section.id}>`;
    });
    const pinned_streams = [];
    $("#stream-list-pinned-streams")[0].append = (...streams) => {
        pinned_streams.push(...streams);
    };

    stream_list.build_stream_list();

    assert.deepEqual(appended_sections, ["pinned-streams", "normal-streams"]);

    assert.deepEqual(pinned_streams, [
        $("<devel-sidebar-row-stub>")[0],
        $("<Rome-sidebar-row-stub>")[0],
    ]);
});

test_ui("rename_stream", ({mock_template, override, override_rewire}) => {
    override_rewire(stream_data, "set_max_channel_width_css_variable", noop);
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);
    override(user_settings, "web_stream_unreads_count_display_policy", 3);
    override(current_user, "user_id", me.user_id);
    initialize_stream_data();

    const sub = stream_data.get_sub_by_name("devel");
    const new_name = "Development";

    stream_data.rename_sub(sub, new_name);

    const $li_stub = $("<li-stub>");

    mock_template("stream_sidebar_row.hbs", false, (payload) => {
        assert.deepEqual(payload, {
            name: "Development",
            id: 1000,
            url: "#narrow/channel/1000-Development",
            is_muted: false,
            invite_only: false,
            is_web_public: false,
            color: payload.color,
            for_modal: false,
            pin_to_top: true,
            can_post_messages: true,
            is_empty_topic_only_channel: false,
            cannot_create_topics_in_channel: false,
        });
        return "<li-stub>";
    });

    const $subscription_block = $.create("development-block");
    const $unread_count = $.create("development-count");
    const $unread_mention_info = $.create("development-unread-mention-info");
    $li_stub.set_find_results(".subscription_block", $subscription_block);
    $subscription_block.set_find_results(".unread_count", $unread_count);
    $subscription_block.set_find_results(".unread_mention_info", $unread_mention_info);

    stream_list.rename_stream(sub);
    assert.equal($unread_count.text(), "99");

    // Reset for the next initialize_stream_data()
    develSub.name = "devel"; // Resets
});

test_ui("refresh_pin", ({override_rewire}) => {
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "maybe_hide_topic_bracket", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);
    initialize_stream_data();

    const sub = make_stream({
        name: "maybe_pin",
        stream_id: 100,
        color: "blue",
        pin_to_top: false,
        subscribed: true,
        can_create_topic_group: everyone_group.id,
        can_send_message_group: everyone_group.id,
    });

    stream_data.add_sub_for_tests(sub);
    // We need to populate current_sections; unclear if this is the best way.
    // stream_list.build_stream_list();

    const pinned_sub = {
        ...sub,
        pin_to_top: true,
    };

    override_rewire(stream_list, "update_count_in_dom", noop);

    let scrolled;
    override_rewire(stream_list, "scroll_stream_into_view", () => {
        // We already passed the test of `stream_sidebar.get_row` to
        // reach this point.
        scrolled = true;
    });

    stream_list.refresh_pinned_or_unpinned_stream(pinned_sub);
    assert.ok(scrolled);
});

test_ui("create_initial_sidebar_rows", ({override, override_rewire, mock_template}) => {
    override(user_settings, "web_stream_unreads_count_display_policy", 2); // Test coverage for this setting.
    override_rewire(stream_list, "update_stream_section_mention_indicators", noop);
    override_rewire(stream_list, "update_dom_with_unread_counts", noop);
    override_rewire(left_sidebar_navigation_area, "update_dom_with_unread_counts", noop);
    override_rewire(stream_list, "set_sections_states", noop);
    initialize_stream_data();

    const html_dict = new Map();

    override(stream_list.stream_sidebar, "has_row_for", () => false);
    override(stream_list.stream_sidebar, "set_row", (stream_id, widget) => {
        html_dict.set(stream_id, widget.get_li().html());
    });

    override_rewire(stream_list, "update_count_in_dom", noop);

    mock_template("stream_sidebar_row.hbs", false, (data) => "<div>stub-html-" + data.name);

    // Test this code with stubs above...
    stream_list.create_initial_sidebar_rows();

    assert.equal(html_dict.get(1000), "<div>stub-html-devel");
    assert.equal(html_dict.get(5000), "<div>stub-html-Denmark");
});