Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
onboarding_steps events: Use OnboardingStepsEvent pydantic type.
Evy Kassirer156bef2a0d31
diff --git a/zerver/actions/onboarding_steps.py b/zerver/actions/onboarding_steps.pyindex 5b7f069949f..e5fd898782b 100644--- a/zerver/actions/onboarding_steps.py+++ b/zerver/actions/onboarding_steps.py@@ -1,7 +1,6 @@-from dataclasses import asdict-from django.db import transaction+from zerver.lib.event_types import OnboardingSteps, OnboardingStepsEventfrom zerver.lib.onboarding_steps import get_next_onboarding_stepsfrom zerver.models import OnboardingStep, UserProfilefrom zerver.tornado.django_api import send_event_on_commit@@ -10,8 +9,10 @@ from zerver.tornado.django_api import send_event_on_commit@transaction.atomic(durable=True)def do_mark_onboarding_step_as_read(user: UserProfile, onboarding_step: str) -> None:OnboardingStep.objects.get_or_create(user=user, onboarding_step=onboarding_step)- event = dict(- type="onboarding_steps",- onboarding_steps=[asdict(step) for step in get_next_onboarding_steps(user)],+ event = OnboardingStepsEvent(+ onboarding_steps=[+ OnboardingSteps(type=step.type, name=step.name)+ for step in get_next_onboarding_steps(user)+ ],)send_event_on_commit(user.realm, event, [user.id])diff --git a/zerver/lib/event_types.py b/zerver/lib/event_types.pyindex 86abfe94dd5..6c58a641605 100644--- a/zerver/lib/event_types.py+++ b/zerver/lib/event_types.py@@ -286,7 +286,7 @@ class OnboardingSteps(BaseModel):class OnboardingStepsEvent(BaseEvent):- type: Literal["onboarding_steps"]+ type: Literal["onboarding_steps"] = "onboarding_steps"onboarding_steps: list[OnboardingSteps]