Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

message_cache: Return the encoded messages from update_message_cache.

Aman Agrawal369c4c9414be
diff --git a/zerver/actions/message_edit.py b/zerver/actions/message_edit.py
index a6b087ca6a5..a30bd918fc6 100644
--- a/zerver/actions/message_edit.py
+++ b/zerver/actions/message_edit.py
@@ -1006,7 +1006,8 @@ def do_update_message(
# This does message.save(update_fields=[...])
save_message_for_edit_use_case(message=target_message)
- event.message_ids = sorted(update_message_cache([target_message]))
+ update_message_cache([target_message])
+ event.message_ids = [target_message.id]
users_to_be_notified = list(map(user_info, ums))
send_event_on_commit(user_profile.realm, event, users_to_be_notified)
diff --git a/zerver/lib/message_cache.py b/zerver/lib/message_cache.py
index 560fc864543..65a74a2456d 100644
--- a/zerver/lib/message_cache.py
+++ b/zerver/lib/message_cache.py
@@ -77,7 +77,7 @@ def message_to_encoded_cache(message: Message, realm_id: int | None = None) -> b
def update_message_cache(
changed_messages: Iterable[Message], realm_id: int | None = None
-) -> list[int]:
+) -> dict[int, bytes]:
"""Updates the message as stored in the to_dict cache (for serving
messages)."""
items_for_remote_cache = {}
@@ -86,7 +86,7 @@ def update_message_cache(
items_for_remote_cache[to_dict_cache_key_id(msg_id)] = msg
cache_set_many(items_for_remote_cache)
- return list(changed_messages_to_dict.keys())
+ return changed_messages_to_dict
def save_message_rendered_content(message: Message, content: str) -> str: