Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
reload-clients: Detach stdio and cwd when daemonizing.
Ben Prew406a311c979f
diff --git a/scripts/reload-clients b/scripts/reload-clientsindex 919a0e824ac..cabcd9efcb5 100755--- a/scripts/reload-clients+++ b/scripts/reload-clients@@ -51,8 +51,10 @@ c = requests.Session()c.mount("http://", HTTPAdapter(max_retries=retry))log_filename = None++# see man 3 daemon for what steps are taken to daemonize a processif args.background:- # Double-fork to daemonize+ # Double-forkpid = os.fork()if pid > 0:sys.exit(0)@@ -62,6 +64,24 @@ if args.background:sys.exit(0)log_filename = "/var/log/zulip/reload-clients.log"+ # Don't hold the working directory (the just-created deployment directory)+ # open for as long as this daemon runs+ os.chdir("/")++ # Detach stdin. A daemon must not hold open a terminal or pipe on stdin.+ devnull_fd = os.open(os.devnull, os.O_RDONLY)+ os.dup2(devnull_fd, sys.stdin.fileno())+ os.close(devnull_fd)++ # Redirect stdout/stderr to the log file to catch uncaught exceptions and keep+ # tee from hanging after script completes.+ # Appending is safe to share with the logging module's handle, since O_APPEND+ # writes are atomic.+ log_fd = os.open(log_filename, os.O_WRONLY | os.O_CREAT | os.O_APPEND, 0o644)+ os.dup2(log_fd, sys.stdout.fileno())+ os.dup2(log_fd, sys.stderr.fileno())+ os.close(log_fd)+logging.Formatter.converter = time.gmtimelogging.basicConfig(format="%(asctime)s reload-clients: %(message)s",