Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

hash_util: Reject non-numeric message ids in channel/topic links.

Evy Kassirer5c83c07cd97a
diff --git a/web/src/hash_util.ts b/web/src/hash_util.ts
index f7bb5102764..bb285a9cd21 100644
--- a/web/src/hash_util.ts
+++ b/web/src/hash_util.ts
@@ -576,6 +576,11 @@ export function decode_stream_topic_from_url(
if (terms[2]?.operator !== "near") {
return null;
}
+ // Callers parse the message id as a number, so a URL with anything
+ // else there is malformed rather than a link to a message.
+ if (!/^\d+$/.test(terms[2].operand)) {
+ return null;
+ }
return {stream_id, topic_name: terms[1].operand, message_id: terms[2].operand};
} catch {
return null;
diff --git a/web/tests/hash_util.test.cjs b/web/tests/hash_util.test.cjs
index f6daad93e30..1865950a359 100644
--- a/web/tests/hash_util.test.cjs
+++ b/web/tests/hash_util.test.cjs
@@ -75,6 +75,37 @@ run_test("hash_util", () => {
encode_decode_operand(operator, operand, "testing.20123");
});
+run_test("decode_stream_topic_from_url", () => {
+ const decode = hash_util.decode_stream_topic_from_url;
+ const channel_url = "#narrow/channel/99-Frontend";
+ const topic_url = `${channel_url}/topic/testing`;
+ assert.deepEqual(decode(channel_url), {stream_id: 99});
+ // The channel name after its id is optional.
+ assert.deepEqual(decode("#narrow/channel/99"), {stream_id: 99});
+ assert.deepEqual(decode(topic_url), {stream_id: 99, topic_name: "testing"});
+ assert.deepEqual(decode(`${topic_url}/near/42`), {
+ stream_id: 99,
+ topic_name: "testing",
+ message_id: "42",
+ });
+
+ // Another origin.
+ assert.equal(decode("https://other.example.com/#narrow/channel/99-Frontend"), null);
+ // Not a narrow.
+ assert.equal(decode("#settings"), null);
+ // No channel, or one that isn't identified by id.
+ assert.equal(decode("#narrow/topic/testing"), null);
+ assert.equal(decode("#narrow/channel/abc"), null);
+ // A message with no topic.
+ assert.equal(decode(`${channel_url}/near/42`), null);
+ // Terms other than near after the topic.
+ assert.equal(decode(`${topic_url}/id/42`), null);
+ assert.equal(decode(`${topic_url}/near/42/x/1`), null);
+ // A message id that isn't a number.
+ assert.equal(decode(`${topic_url}/near/abc`), null);
+ assert.equal(decode(`${topic_url}/near/12abc`), null);
+});
+
run_test("pm_with_url", () => {
assert.equal(hash_util.pm_with_url("15"), "#narrow/dm/15-Hamlet");
assert.equal(hash_util.pm_with_url("15,9999"), "#narrow/dm/15,9999-group");