Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

user_card_popover: Close the card on scroll instead of recentering.

Sairam Bisoyi7062379cd79f
diff --git a/web/src/popover_menus.ts b/web/src/popover_menus.ts
index d1df3d374d3..3e442b9449f 100644
--- a/web/src/popover_menus.ts
+++ b/web/src/popover_menus.ts
@@ -258,15 +258,6 @@ export const default_popover_props: Partial<tippy.Props> = {
$tippy_box.attr("data-reference-hidden") !== undefined;
if ($tippy_box.hasClass("show-when-reference-hidden")) {
- // Show user card popover as an overlay if we are not sure about position of the
- // reference. This can happen when popover reference has been replaced or hidden.
- if (
- is_reference_outside_window &&
- $tippy_box.find("#user_card_popover").length > 0
- ) {
- $("body").append($("<div>").attr("id", "popover-overlay-background"));
- instance.setProps(get_props_for_popover_centering(instance.props));
- }
return;
}
diff --git a/web/src/user_card_popover.ts b/web/src/user_card_popover.ts
index 1544e3c4b27..20aad5ffadd 100644
--- a/web/src/user_card_popover.ts
+++ b/web/src/user_card_popover.ts
@@ -708,11 +708,6 @@ function toggle_sidebar_user_card_popover($target: JQuery): void {
"compose_private_message",
"user_sidebar",
"left",
- false,
- (instance) => {
- /* See comment in get_props_for_popover_centering for explanation of this. */
- $(instance.popper).find(".tippy-box").addClass("show-when-reference-hidden");
- },
);
current_user_sidebar_user_id = user.user_id;