Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

channel_settings: Use standard subsection header for advanced config.

Sahil Batraa2fd0f8afab6
diff --git a/web/styles/settings.css b/web/styles/settings.css
index 8f4d017d564..dcf74fd5425 100644
--- a/web/styles/settings.css
+++ b/web/styles/settings.css
@@ -669,13 +669,11 @@ input[type="checkbox"] {
.advanced-configurations-container {
.advance-config-toggle-area {
cursor: pointer;
- display: flex;
- align-items: center;
- gap: 0 0.625em;
-
- .settings-subsection-title {
- margin: 4px 0;
- }
+ /* Unlike other subsection headers, which wrap their save/discard
+ widget below the title, this row is just a caret and a title;
+ a long translated title should wrap within the title rather
+ than dropping below the caret. */
+ flex-wrap: nowrap;
.toggle-advanced-configurations-icon {
font-size: 1.4286em; /* 20px at 14px / em */
diff --git a/web/templates/stream_settings/new_stream_configuration.hbs b/web/templates/stream_settings/new_stream_configuration.hbs
index 673526e7bdc..896a3f15bc4 100644
--- a/web/templates/stream_settings/new_stream_configuration.hbs
+++ b/web/templates/stream_settings/new_stream_configuration.hbs
@@ -22,11 +22,9 @@
}}
<div class="advanced-configurations-container">
- <div class="advance-config-title-container">
- <div class="advance-config-toggle-area">
- <i class="fa fa-sm fa-caret-right toggle-advanced-configurations-icon" aria-hidden="true"></i>
- <h3 class="settings-subsection-title"><span>{{t 'Advanced configuration' }}</span></h3>
- </div>
+ <div class="subsection-header advance-config-toggle-area">
+ <i class="fa fa-sm fa-caret-right toggle-advanced-configurations-icon" aria-hidden="true"></i>
+ <h3 class="settings-subsection-title">{{t 'Advanced configuration' }}</h3>
</div>
<div class="advanced-configurations-collapase-view hide">
{{> channel_permissions .