Zulip server and web application. Open-source team chat that helps teams stay productive and focused.
claude: Fold "No detail is too small" into the UI testing checklist.
Evy Kassirerb234b0a98d32
diff --git a/.claude/rules/ui-testing.md b/.claude/rules/ui-testing.mdindex 490bbd1a2a2..4bc01cb7920 100644--- a/.claude/rules/ui-testing.md+++ b/.claude/rules/ui-testing.md@@ -11,19 +11,28 @@ catches issues that automated tests miss. **Treat this checklist asblocking, not advisory** — every applicable item must be verifiedbefore the change is ready.+Most of these items can be completed by an agent. Start with+analyzing the files, because it is cheaper than the `/visual-test`+skill (`.claude/skills/visual-test/SKILL.md`). For things you aren't+sure about, ensure either the user completes the relevant visual+tests or you've run the visual test skill on them.+## Visual appearance-- Is the new UI consistent with similar elements (fonts, colors, sizes)?- Find the closest existing analogues and compare carefully.+- Is the new UI consistent with similar elements (alignment, spacing,+ fonts, colors, sizes)? Find the closest existing analogues and compare+ carefully.- Is alignment correct, both vertically and horizontally? Measureprogrammatically with `getBoundingClientRect()` when in doubt —don't eyeball it.-- Do clickable elements have hover behavior consistent with similar UI?-- If elements can be disabled, does the disabled state look right?+- Does every state look right and match similar UI: hover, active,+ disabled, focused, selected, empty, overflowing?- Did the change accidentally affect other parts of the UI? Use- `git grep` to check if modified CSS is used elsewhere. CSS changes- are notorious for unintended consequences — check every page and- component that shares the selectors you modified.+ `git grep` to check if modified CSS is used elsewhere.+- CSS changes are notorious for unintended consequences — check every+ page and component that shares the selectors you modified, and+ demonstrate with pixel-precise before/after comparisons that there+ are none.- Check all of the above in both light and dark themes when thechange could plausibly affect colors, contrast, or theme-dependentimagery. Pure geometry/typography changes (`font-size`,@@ -36,13 +45,16 @@ before the change is ready.- Does the UI look good at different window sizes? Check wide desktop(1920px), typical laptop (1280px), tablet, and narrow phone (480px).+ Any widths between these values should also work.- Would the UI break if translated strings were 1.5x longer thanEnglish? What if they were half as long? Both directions matter.+ Think about right-to-left languages too.## Functionality- Are live updates working as expected?- Is keyboard navigation, including tabbing to interactive elements, working?+- Do screen readers get sensible labels and roles for new elements?- If the feature affects the message view, try different narrows: topic,channel, Combined feed, direct messages.- If the feature affects the compose box, test both channel messages anddiff --git a/AGENTS.md b/AGENTS.mdindex 9b9418bff43..859c0cb3a28 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -36,39 +36,13 @@ change should make the codebase more maintainable and easier to read.### No detail is too small-Zulip holds itself to a high bar for polish because users depend on-this software daily, and because the project is built to last for-decades. There is no category of "minor issue" that is acceptable-to ship — if something is broken in any context where a user would-encounter it, it must be fixed before merging. The project's-extensive investment in testing, tooling, and review processes exists-precisely so that these issues get caught and fixed, not so that they-can be classified as low-priority and deferred.--This philosophy extends to every aspect of the product:--- **Visual precision matters.** Alignment, spacing, colors, and font- sizes must be consistent with similar existing UI. When making CSS- changes, you must demonstrate with pixel-precise before/after- comparisons that there are no unintended side effects.-- **Every state matters.** UI must look correct in all its states:- hover, active, disabled, focused, selected, empty, overflowing.- Changes that could plausibly affect colors, contrast, or- theme-dependent imagery must work in both light and dark themes;- changes whose effect can't reasonably vary with theme (pure- geometry/typography — `font-size`, `line-height`, `margin`,- `padding`, `display`, `font-weight`, etc.) only need a single- theme verified.-- **Every window size matters.** UI must look good from wide desktop- (1920px) down to narrow phone screens (480px).-- **Every language matters.** Translated strings can be 1.5x longer- than English or half as short. UI must handle both extremes without- breaking layout. Think about right-to-left languages too.-- **Every interaction path matters.** Keyboard navigation, screen- readers, permission levels, feature interactions (banners- overlapping, resolved topics, muted messages), and edge cases in- data (empty lists, very long names, single items vs. many) must all- be considered.+There is no category of "minor issue" that is acceptable to ship —+if something is broken in any state, size, theme, or language where+a user would encounter it, it must be fixed before merging. If a fix+would require a design decision, raise it as a question rather than+shipping the broken state. See `.claude/rules/ui-testing.md` for+what to test for UI changes (the file loads automatically when you+work on frontend files).The right attitude is: "What could go wrong, and how do I verify thatit doesn't?" not "It looks fine to me." **What isn't tested probably