Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

stripe: Check charge_automatically before invoice status.

Aman Agrawalc6662bbcaa9d
diff --git a/corporate/lib/stripe.py b/corporate/lib/stripe.py
index d8fc75e3124..205b689df11 100644
--- a/corporate/lib/stripe.py
+++ b/corporate/lib/stripe.py
@@ -1355,7 +1355,7 @@ class BillingSession(ABC):
is_created_for_free_trial_upgrade=current_plan_id is not None and on_free_trial,
)
- if stripe_invoice.status != "paid" and charge_automatically:
+ if charge_automatically and stripe_invoice.status != "paid":
# Stripe can take its sweet hour to charge customers after creating an invoice.
# Since we want to charge customers immediately, we charge them manually.
# Then poll for the status of the invoice to see if the payment succeeded.