Skip to content

armgit / zulip

Public Imported from GitHub
0

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

left_sidebar: Don't show view tooltips on mouse-opened popover focus.

Pratik Chandae6664eaf2efd
diff --git a/web/src/left_sidebar_tooltips.ts b/web/src/left_sidebar_tooltips.ts
index 94bb3de9de1..91d772533c3 100644
--- a/web/src/left_sidebar_tooltips.ts
+++ b/web/src/left_sidebar_tooltips.ts
@@ -24,6 +24,16 @@ export function initialize(): void {
delay: EXTRA_LONG_HOVER_DELAY,
appendTo: () => document.body,
onShow(instance) {
+ // Popover menus focus their first item when opened by a mouse click;
+ // don't show the tooltip for this programmatic focus. Keyboard focus
+ // should still show the tooltip without a hover.
+ if (
+ instance.reference.matches(":focus:not(:focus-visible)") &&
+ !instance.reference.matches(":hover")
+ ) {
+ return false;
+ }
+
const $container = $(instance.popper).find(".views-tooltip-container");
let display_count;
const sidebar_option = $container.attr("data-view-code");
@@ -101,6 +111,7 @@ export function initialize(): void {
offset: [0, 40],
});
}
+ return undefined;
},
onHidden(instance) {
instance.destroy();